Fix fetching L0 and CUDA headers and add UMF_CUDA_INCLUDE_DIR #832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bratpiorka
approved these changes
Oct 24, 2024
ldorau
force-pushed
the
Fix_fetching_L0_and_CUDA_headers_and_add_UMF_CUDA_INCLUDE_DIR
branch
from
a88268c to
10adcdb
Compare
vinser52
approved these changes
Oct 24, 2024
pbalcer
approved these changes
Oct 24, 2024
lukaszstolarczuk
requested changes
Oct 24, 2024
ldorau
force-pushed
the
Fix_fetching_L0_and_CUDA_headers_and_add_UMF_CUDA_INCLUDE_DIR
branch
from
10adcdb to
a11f927
Compare
ldorau
force-pushed
the
Fix_fetching_L0_and_CUDA_headers_and_add_UMF_CUDA_INCLUDE_DIR
branch
2 times, most recently
from
151d58e to
b887d38
Compare
ldorau
force-pushed
the
Fix_fetching_L0_and_CUDA_headers_and_add_UMF_CUDA_INCLUDE_DIR
branch
5 times, most recently
from
8b9bb5e to
f2615bc
Compare
|
@lukaszstolarczuk resolve your issues, please |
lukaszstolarczuk
approved these changes
Oct 25, 2024
Fetch L0 loader only if needed i.e.: if building L0 provider is ON and L0 headers are not provided by the user (via setting UMF_LEVEL_ZERO_INCLUDE_DIR). Fetch CUDA only if needed i.e.: if building CUDA provider is ON and CUDA headers are not provided by the user (via setting UMF_CUDA_INCLUDE_DIR). Ref: oneapi-src#825 Fixes: oneapi-src#827 Signed-off-by: Lukasz Dorau <[email protected]>
ldorau
force-pushed
the
Fix_fetching_L0_and_CUDA_headers_and_add_UMF_CUDA_INCLUDE_DIR
branch
from
f2615bc to
89025a1
Compare
|
Rebased |
ldorau
deleted the
Fix_fetching_L0_and_CUDA_headers_and_add_UMF_CUDA_INCLUDE_DIR
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix fetching L0 and CUDA headers and add
UMF_CUDA_INCLUDE_DIR.Fetch L0 loader only if needed i.e.:
if building L0 provider is ON and L0 headers are not provided by the user (via setting
UMF_LEVEL_ZERO_INCLUDE_DIR).Fetch CUDA only if needed i.e.:
if building CUDA provider is ON and CUDA headers are not provided by the user (via setting
UMF_CUDA_INCLUDE_DIR).Ref: #825
Fixes:: #827
Checklist