Fix devdax_open_ipc_handle() and devdax_close_ipc_handle() #834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bratpiorka
approved these changes
Oct 24, 2024
ldorau
force-pushed
the
Fix_devdax_open_ipc_handle
branch
from
e3a5fcf to
8ec05ad
Compare
ldorau
changed the title
devdax_open_ipc_handle()devdax_open_ipc_handle()
ldorau
force-pushed
the
Fix_devdax_open_ipc_handle
branch
5 times, most recently
from
ba0cb7b to
e640016
Compare
devdax_open_ipc_handle() has to use the path of the remote /dev/dax got from the IPC handle, not the local one. devdax_open_ipc_handle() has to use also the memory protection got from the IPC handle, so let's add the memory protection to the IPC handle. devdax_open_ipc_handle() should mmap only the required range of memory, not the whole /dev/dax device, so let's add the length of the allocation to the IPC handle. devdax_close_ipc_handle() should unmap only the required range of memory, not the whole /dev/dax device. Signed-off-by: Lukasz Dorau <[email protected]>
ldorau
changed the title
devdax_open_ipc_handle()
ldorau
force-pushed
the
Fix_devdax_open_ipc_handle
branch
from
e640016 to
7706431
Compare
4 tasks
|
It requires more changes, closing for now, will be reopened |
|
Reopened in #838 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix devdax_open_ipc_handle() and devdax_close_ipc_handle()
devdax_open_ipc_handle() has to use the path of the remote
/dev/dax got from the IPC handle, not the local one.
devdax_open_ipc_handle() has to use also the memory protection
got from the IPC handle, so let's add the memory protection
to the IPC handle.
devdax_open_ipc_handle() should mmap only the required range of memory,
not the whole /dev/dax device, so let's add the length of the allocation
to the IPC handle.
devdax_close_ipc_handle() should unmap only the required range of memory,
not the whole /dev/dax device.
Checklist