Add IPC tests for using an allocation after umfCloseIPCHandle()
#840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldorau
force-pushed
the
Add_IPC_tests_for_umfPoolMalloc_after_umfCloseIPCHandle
branch
from
ad0aa59 to
c4a3db9
Compare
|
Rebased |
ldorau
force-pushed
the
Add_IPC_tests_for_umfPoolMalloc_after_umfCloseIPCHandle
branch
from
c4a3db9 to
ac0f5bd
Compare
ldorau
force-pushed
the
Add_IPC_tests_for_umfPoolMalloc_after_umfCloseIPCHandle
branch
from
ac0f5bd to
30d0ea1
Compare
bratpiorka
approved these changes
Oct 30, 2024
ldorau
force-pushed
the
Add_IPC_tests_for_umfPoolMalloc_after_umfCloseIPCHandle
branch
from
30d0ea1 to
ebe4ac6
Compare
vinser52
reviewed
Oct 30, 2024
test/ipcFixtures.hpp
Outdated
| @@ -328,8 +340,19 @@ TEST_P(umfIpcTest, AllocFreeAllocTest) { | |||
| ret = umfPoolFree(pool.get(), ptr); | |||
| EXPECT_EQ(ret, UMF_RESULT_SUCCESS); | |||
|
|
|||
| // Test if umfCloseIPCHandle() did not corrupt the pool | |||
| // and if umfPoolMalloc() works correctly after umfCloseIPCHandle(). | |||
| ptr = umfPoolMalloc(pool.get(), SIZE); | |||
There was a problem hiding this comment.
But L325 already calls umfPoolMalloc after the umfCloseIPCHandle function. Why we need to check it again?
There was a problem hiding this comment.
Right. Changed to test for using an allocation after umfCloseIPCHandle().
vinser52
reviewed
Oct 30, 2024
test/ipcFixtures.hpp
Outdated
Comment on lines
223
to
234
| // Test if umfCloseIPCHandle() did not corrupt the pool | ||
| // and if umfPoolMalloc() works correctly after umfCloseIPCHandle(). | ||
| ptr = (int *)umfPoolMalloc(pool.get(), SIZE); | ||
| EXPECT_NE(ptr, nullptr); | ||
|
|
||
| // use the allocated memory - fill it with a 0xAB pattern | ||
| const uint32_t pattern = 0xAB; | ||
| memAccessor->fill(ptr, SIZE, &pattern, sizeof(pattern)); | ||
|
|
||
| ret = umfPoolFree(pool.get(), ptr); | ||
| EXPECT_EQ(ret, UMF_RESULT_SUCCESS); | ||
|
|
There was a problem hiding this comment.
It looks like a duplication. The AllocFreeAllocTest tests the same scenario.
ldorau
changed the title
umfPoolMalloc() after umfCloseIPCHandle()umfCloseIPCHandle()
Add IPC tests for using an allocation after umfCloseIPCHandle(). Test if umfPoolMalloc() returns a usable pointer after umfCloseIPCHandle(). Signed-off-by: Lukasz Dorau <[email protected]>
ldorau
force-pushed
the
Add_IPC_tests_for_umfPoolMalloc_after_umfCloseIPCHandle
branch
from
ebe4ac6 to
65e988a
Compare
vinser52
approved these changes
Oct 30, 2024
ldorau
deleted the
Add_IPC_tests_for_umfPoolMalloc_after_umfCloseIPCHandle
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add IPC tests for using an allocation after
umfCloseIPCHandle().Test if
umfPoolMalloc()returns a usable pointer afterumfCloseIPCHandle().Checklist