fix for the apply of the HWLOC security patch #854
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatKamin
approved these changes
Oct 31, 2024
bratpiorka
force-pushed
the
rrudnick_hwloc_patch_fix_0.9
branch
from
c3dd160 to
a4646af
Compare
|
to be rebased after #857 |
bratpiorka
force-pushed
the
rrudnick_hwloc_patch_fix_0.9
branch
from
a4646af to
4ed4437
Compare
bratpiorka
requested review from
lukaszstolarczuk
and removed request for
KFilipek
bratpiorka
force-pushed
the
rrudnick_hwloc_patch_fix_0.9
branch
from
4ed4437 to
ef1e1cd
Compare
lukaszstolarczuk
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for the apply of the HWLOC security patch
This is a fix for a scenario where the user runs the cmake configuration with the UMF_LINK_HWLOC_STATICALLY setting multiple times for the same build directory. On the first run, cmake downloads the HWLOC sources and successfully applies the required security patch, but the patching fails the second time (the patch has already been applied). This PR fixes this error.
NOTE: this is a v0.9x ver - previously reviewed here: #849