Skip to content

Replace MALLOC_PROVIDER_OPS with BA_GLOBAL_PROVIDER_OPS #876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ldorau
Copy link
Contributor

@ldorau ldorau commented Nov 6, 2024

Description

Replace MALLOC_PROVIDER_OPS with BA_GLOBAL_PROVIDER_OPS:

  1. Use umf_ba_global_*() API in MALLOC_PROVIDER_OPS,
  2. Rename provider_malloc to provider_ba_global,
  3. Rename MALLOC_PROVIDER_OPS to BA_GLOBAL_PROVIDER_OPS.

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly

@ldorau ldorau requested a review from a team as a code owner November 6, 2024 13:20
@ldorau ldorau requested a review from bratpiorka November 6, 2024 13:30
@ldorau ldorau force-pushed the Replace_MALLOC_PROVIDER_OPS_with_BA_GLOBAL_PROVIDER_OPS branch from 6fe8aa5 to 468a26d Compare November 6, 2024 13:39
@bratpiorka bratpiorka requested a review from vinser52 November 6, 2024 13:50
@ldorau ldorau force-pushed the Replace_MALLOC_PROVIDER_OPS_with_BA_GLOBAL_PROVIDER_OPS branch 2 times, most recently from 9dc77fc to 84ae533 Compare November 7, 2024 08:16
Skip testing umf_test-disjointPool under helgrind,
because of the assert in helgrind:

Helgrind: hg_main.c:308 (lockN_acquire_reader): \
  Assertion 'lk->kind == LK_rdwr' failed.

Signed-off-by: Lukasz Dorau <[email protected]>
@ldorau ldorau force-pushed the Replace_MALLOC_PROVIDER_OPS_with_BA_GLOBAL_PROVIDER_OPS branch 2 times, most recently from 2a3d4e4 to abc6803 Compare November 7, 2024 08:28
Fix warning:
warning: passing argument 4 of ‘cuda_copy’ discards ‘const’ qualifier \
         from pointer target type [-Wdiscarded-qualifiers]

Signed-off-by: Lukasz Dorau <[email protected]>
@ldorau ldorau force-pushed the Replace_MALLOC_PROVIDER_OPS_with_BA_GLOBAL_PROVIDER_OPS branch from abc6803 to f547820 Compare November 7, 2024 08:31
@ldorau
Copy link
Contributor Author

ldorau commented Nov 7, 2024

@ldorau ldorau merged commit e08e311 into oneapi-src:main Nov 7, 2024
74 checks passed
@ldorau ldorau deleted the Replace_MALLOC_PROVIDER_OPS_with_BA_GLOBAL_PROVIDER_OPS branch November 7, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants