IPC API #88
Merged
IPC API #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinser52
force-pushed
the
svinogra_ipc_api
branch
2 times, most recently
from
6789c2c to
8f1fb69
Compare
igchor
reviewed
Dec 20, 2023
igchor
reviewed
Dec 20, 2023
vinser52
force-pushed
the
svinogra_ipc_api
branch
2 times, most recently
from
da6584c to
60f7560
Compare
vinser52
force-pushed
the
svinogra_ipc_api
branch
2 times, most recently
from
7daa17f to
e61e046
Compare
vinser52
force-pushed
the
svinogra_ipc_api
branch
2 times, most recently
from
84a0d89 to
416c25d
Compare
vinser52
force-pushed
the
svinogra_ipc_api
branch
2 times, most recently
from
4dc141a to
b0956d6
Compare
vinser52
force-pushed
the
svinogra_ipc_api
branch
12 times, most recently
from
9816c61 to
f780bf0
Compare
vinser52
force-pushed
the
svinogra_ipc_api
branch
2 times, most recently
from
0a5885a to
8dd740f
Compare
bratpiorka
requested changes
Mar 13, 2024
igchor
reviewed
Mar 13, 2024
vinser52
force-pushed
the
svinogra_ipc_api
branch
6 times, most recently
from
7e17bc4 to
c70791f
Compare
|
Can you please make issue/issues out of your "remaining tasks/items" (from PR description)? |
vinser52
force-pushed
the
svinogra_ipc_api
branch
3 times, most recently
from
b07b9dd to
2cbaa1a
Compare
bratpiorka
approved these changes
Apr 3, 2024
|
@vinser52 overall LGTM |
@bratpiorka I am going to create issues today (right now). |
This was referenced Apr 3, 2024
vinser52
force-pushed
the
svinogra_ipc_api
branch
2 times, most recently
from
a5c30b3 to
e03a0a3
Compare
igchor
approved these changes
Apr 3, 2024
3 tasks
|
drd and helgrind CI jobs should be fixed after PR #411 is merged |
vinser52
force-pushed
the
svinogra_ipc_api
branch
from
e03a0a3 to
49daedf
Compare
This was referenced Apr 5, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces IPC API to UMF. The main use cases so far are from the GPU domain (L0, CUDA have such capabilities). The API is pretty similar to what L0 and CUDA have, but it also could be applied for shared memory or file-backed memory.
This PR is big enough, but still it does not contain everything we need.
The remaining tasks/items are the following:
critnibdata structure (in fact just a map, not a real cache with eviction policy).uthashdata structure that supports arbitrary key type and is more suitable for caching on a consumer side where the key is remote PID + address