Remove the UMF_MEM_MAP_SYNC flag
#887
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lplewa
reviewed
Nov 12, 2024
include/umf/memory_provider.h
Outdated
| @@ -21,7 +21,8 @@ extern "C" { | |||
| typedef enum umf_memory_visibility_t { | |||
| UMF_MEM_MAP_PRIVATE = 1, ///< private memory mapping | |||
| UMF_MEM_MAP_SHARED, ///< shared memory mapping (Linux only) | |||
| UMF_MEM_MAP_SYNC, ///< direct mapping of persistent memory (supported only for files supporting DAX, Linux only) | |||
| UMF_MEM_MAP_SYNC = | |||
There was a problem hiding this comment.
i think attribute((deprecated)) should work here
There was a problem hiding this comment.
please just redefine new flag (remove "UMF_MEM_MAP_SYNC =")
There was a problem hiding this comment.
On the UMF tech meeting, we agreed that UMF_MEM_MAP_SYNC can be simply removed.
It is an API/ABI breaking change but in this particular case, it is OK because we are mostly sure that nobody uses it.
ldorau
changed the title
UMF_MEM_MAP_SYNC flagUMF_MEM_MAP_SYNC flag
ldorau
force-pushed
the
Deprecate_the_UMF_MEM_MAP_SYNC_flag
branch
from
ab94622 to
2e81b59
Compare
Make utils_mmap_file() detect DAX using MAP_SYNC flag. Add bool *map_sync argument to utils_mmap_file(). map_sync is set to true only if memory was mapped with MAP_SYNC, what means it is a DAX file/device. Signed-off-by: Lukasz Dorau <[email protected]>
Remove the UMF_MEM_MAP_SYNC flag, UMF_MEM_MAP_SHARED should be used instead. Verify if /dev/dax was mapped with MAP_SYNC. Signed-off-by: Lukasz Dorau <[email protected]>
ldorau
force-pushed
the
Deprecate_the_UMF_MEM_MAP_SYNC_flag
branch
from
2e81b59 to
199e754
Compare
vinser52
approved these changes
Nov 13, 2024
lplewa
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove the
UMF_MEM_MAP_SYNCflag,UMF_MEM_MAP_SHAREDshould be used instead.Verify if /dev/dax was mapped with
MAP_SYNC.Checklist