Fix linking #89
Merged
Fix linking #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some libraries that were dependencies of UMF were not link to UMF but rather directly to tests and benchmark. Fix this by extending add_umf_library and passing required libs there.
igchor
force-pushed
the
fix_build_dependencies
branch
from
e0043fd to
e64c4c0
Compare
vinser52
approved these changes
Dec 20, 2023
ldorau
approved these changes
Dec 21, 2023
|
Thanks, @igchor ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some libraries that were dependencies of UMF were not link to UMF but rather directly to tests and benchmark. Fix this by extending add_umf_library and passing required libs there.