Skip to content

Temporarily disable failing windows-2022 clang CI job #909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ldorau
Copy link
Contributor

@ldorau ldorau commented Nov 18, 2024

Description

Temporarily disable failing windows-2022 clang CI job, because of the error:

Error: C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\Llvm\x64\lib\clang\18\include\__stddef_ptrdiff_t.h(15): fatal error RC1012: mismatched parenthesis : missing ' [D:\a\unified-memory-framework\unified-memory-framework\build\src\umf.vcxproj]

See:
https://github.com/oneapi-src/unified-memory-framework/actions/runs/11892350813/job/33136923719
https://github.com/oneapi-src/unified-memory-framework/actions/runs/11893427436/job/33141053575

Ref: #910

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly

Copy link
Contributor

@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logs says that clang version has changed on the runner image, but quick look and I can't find any upsteram issue neither for GHA nor for clang...

@lplewa
Copy link
Contributor

lplewa commented Nov 18, 2024

😮‍💨

@bratpiorka
Copy link
Contributor

please try replace

#include <stddef.h> /* ptrdiff_t */

in /src/uthash/uthash.h with

typedef __int64_t ptrdiff_t

@lukaszstolarczuk
Copy link
Contributor

please try replace

#include <stddef.h> /* ptrdiff_t */

in /src/uthash/uthash.h with

typedef __int64_t ptrdiff_t

I don't think this is an issue - I just ran a build from a commit before uthash merge, and there's the same issue:
https://github.com/lukaszstolarczuk/unified-memory-framework/actions/runs/11895775204/job/33147063860#step:6:38

also, UR does not contain uthash and they observe the same issue

@ldorau ldorau force-pushed the Temporarily_disable_failing_windows-2022_clang_CI_job branch from fbdb7b7 to 467be17 Compare November 18, 2024 17:23
@ldorau
Copy link
Contributor Author

ldorau commented Nov 19, 2024

please try replace

#include <stddef.h> /* ptrdiff_t */

in /src/uthash/uthash.h with

typedef __int64_t ptrdiff_t

It does not fix the issue:
https://github.com/ldorau/unified-memory-framework/actions/runs/11908845168/job/33185051024

@bratpiorka bratpiorka merged commit 3c4a84b into oneapi-src:main Nov 19, 2024
77 checks passed
@ldorau ldorau deleted the Temporarily_disable_failing_windows-2022_clang_CI_job branch November 19, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants