Skip to content

Make all ops of the OS memory provider static #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Make all ops of the OS memory provider static #92

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions src/provider/provider_os_memory.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ os_copy_and_translate_params(umf_os_memory_provider_params_t *in_params,
&out_config->nodemask);
}

umf_result_t os_initialize(void *params, void **provider) {
static umf_result_t os_initialize(void *params, void **provider) {
umf_result_t ret;

if (provider == NULL || params == NULL) {
Expand Down Expand Up @@ -226,7 +226,7 @@ umf_result_t os_initialize(void *params, void **provider) {
return UMF_RESULT_SUCCESS;
}

void os_finalize(void *provider) {
static void os_finalize(void *provider) {
if (provider == NULL) {
assert(0);
return;
Expand Down Expand Up @@ -342,8 +342,8 @@ static umf_result_t os_free(void *provider, void *ptr, size_t size) {
return UMF_RESULT_SUCCESS;
}

void os_get_last_native_error(void *provider, const char **ppMessage,
int32_t *pError) {
static void os_get_last_native_error(void *provider, const char **ppMessage,
int32_t *pError) {
(void)provider; // unused

if (ppMessage == NULL || pError == NULL) {
Expand Down Expand Up @@ -377,8 +377,8 @@ void os_get_last_native_error(void *provider, const char **ppMessage,
*ppMessage = TLS_last_native_error.msg_buff;
}

umf_result_t os_get_recommended_page_size(void *provider, size_t size,
size_t *page_size) {
static umf_result_t os_get_recommended_page_size(void *provider, size_t size,
size_t *page_size) {
(void)size; // unused

if (provider == NULL || page_size == NULL) {
Expand All @@ -390,14 +390,14 @@ umf_result_t os_get_recommended_page_size(void *provider, size_t size,
return UMF_RESULT_SUCCESS;
}

umf_result_t os_get_min_page_size(void *provider, void *ptr,
size_t *page_size) {
static umf_result_t os_get_min_page_size(void *provider, void *ptr,
size_t *page_size) {
(void)ptr; // unused

return os_get_recommended_page_size(provider, 0, page_size);
}

umf_result_t os_purge_lazy(void *provider, void *ptr, size_t size) {
static umf_result_t os_purge_lazy(void *provider, void *ptr, size_t size) {
if (provider == NULL || ptr == NULL) {
return UMF_RESULT_ERROR_INVALID_ARGUMENT;
}
Expand All @@ -417,7 +417,7 @@ umf_result_t os_purge_lazy(void *provider, void *ptr, size_t size) {
return UMF_RESULT_SUCCESS;
}

umf_result_t os_purge_force(void *provider, void *ptr, size_t size) {
static umf_result_t os_purge_force(void *provider, void *ptr, size_t size) {
if (provider == NULL || ptr == NULL) {
return UMF_RESULT_ERROR_INVALID_ARGUMENT;
}
Expand All @@ -437,7 +437,7 @@ umf_result_t os_purge_force(void *provider, void *ptr, size_t size) {
return UMF_RESULT_SUCCESS;
}

const char *os_get_name(void *provider) {
static const char *os_get_name(void *provider) {
(void)provider; // unused
return "OS";
}
Expand Down