Update Cuda provider config API #921
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinser52
force-pushed
the
svinogra_cuda_params
branch
3 times, most recently
from
4b554ef to
0199253
Compare
kswiecicki
approved these changes
Nov 21, 2024
| umf_cuda_memory_provider_params_handle_t cu_params = NULL; | ||
| umf_result_t umf_result = umfCudaMemoryProviderParamsCreate(&cu_params); | ||
| if (umf_result != UMF_RESULT_SUCCESS) { | ||
| fprintf(stderr, "Failed to create level zero params!\n"); |
There was a problem hiding this comment.
[...] CUDA memory provider params!, same with the rest of the error messages in the consumer and producer.
vinser52
force-pushed
the
svinogra_cuda_params
branch
2 times, most recently
from
bc080fa to
c9c0cc2
Compare
|
general note: when referring to a specific UMF pool provider/implementation, we should always use capital letters, e.g. we should write ‘UMF CUDA Memory Provider is an example of a memory provider implemented in UMF’ etc. We should also never write ‘Cuda’. Always use ‘CUDA’ in comments, and ‘cuda’ only as part of C variables/names, such as ‘umf_cuda_params’ etc. |
bratpiorka
requested changes
Nov 22, 2024
| /// @brief Create a struct to store parameters of the Cuda memory provider. | ||
| /// @param hParams [out] handle to the newly created parameters struct. | ||
| /// @return UMF_RESULT_SUCCESS on success or appropriate error code on failure. | ||
| umf_result_t umfCudaMemoryProviderParamsCreate( |
There was a problem hiding this comment.
please always write "CUDA" using capital letters as this is an acronym
vinser52
force-pushed
the
svinogra_cuda_params
branch
from
c9c0cc2 to
d3a1398
Compare
bratpiorka
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change the Cuda provider config as we agreed in #844
Checklist