-
Notifications
You must be signed in to change notification settings - Fork 35
Update File provider config API #927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c9f4b11
to
3928cdc
Compare
3928cdc
to
55debf5
Compare
55debf5
to
52eef19
Compare
877d0e1
to
0a2d0c3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code coverage of the src/provider/provider_file_memory.c
file on the main branch is 81% while on this PR 78.8% - it could be improved, so that it does not decrease.
The main reason for code coverage decrease is because of these lines: #if defined(_WIN32) || defined(UMF_NO_HWLOC)
umf_memory_provider_ops_t *umfFileMemoryProviderOps(void) {
// not supported
return NULL;
}
umf_result_t umfFileMemoryProviderParamsCreate(
umf_file_memory_provider_params_handle_t *hParams, const char *path) {
(void)hParams;
(void)path;
return UMF_RESULT_ERROR_NOT_SUPPORTED;
}
umf_result_t umfFileMemoryProviderParamsDestroy(
umf_file_memory_provider_params_handle_t hParams) {
(void)hParams;
return UMF_RESULT_ERROR_NOT_SUPPORTED;
}
umf_result_t umfFileMemoryProviderParamsSetPath(
umf_file_memory_provider_params_handle_t hParams, const char *path) {
(void)hParams;
(void)path;
return UMF_RESULT_ERROR_NOT_SUPPORTED;
}
umf_result_t umfFileMemoryProviderParamsSetProtection(
umf_file_memory_provider_params_handle_t hParams, unsigned protection) {
(void)hParams;
(void)protection;
return UMF_RESULT_ERROR_NOT_SUPPORTED;
}
umf_result_t umfFileMemoryProviderParamsSetVisibility(
umf_file_memory_provider_params_handle_t hParams,
umf_memory_visibility_t visibility) {
(void)hParams;
(void)visibility;
return UMF_RESULT_ERROR_NOT_SUPPORTED;
}
#else // !defined(_WIN32) && !defined(UMF_NO_HWLOC) We have no tests when provider is disabled at build time. And it is true for all providers. |
0a2d0c3
to
0325f30
Compare
Ok, I have added corresponding test. |
The new code coverage of the |
0325f30
to
31372be
Compare
Description
Change the File Provider config as we agreed in #844.
Checklist