Skip to content

Move level zero helpers to utils and use it in benchmarks #945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ldorau
Copy link
Contributor

@ldorau ldorau commented Nov 28, 2024

Description

Move level_zero_helpers to utils and use it in benchmarks

  1. Add utils_ze_ prefix to all L0 helper functions.
  2. Move level_zero_helpers to utils and rename it to utils_level_zero.
  3. Use new utils_level_zero in benchmarks.

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly

@ldorau ldorau force-pushed the Move_level_zero_helpers_to_utils branch 5 times, most recently from 17371d1 to bf41d7e Compare November 28, 2024 09:58
@ldorau ldorau force-pushed the Move_level_zero_helpers_to_utils branch from bf41d7e to a3f7c31 Compare November 28, 2024 10:52
Fix level_zero_helpers.cpp:
- make local functions static
- initialize level_zero_init_flag with UTIL_ONCE_FLAG_INIT

Signed-off-by: Lukasz Dorau <[email protected]>
@ldorau ldorau force-pushed the Move_level_zero_helpers_to_utils branch from a3f7c31 to 66b0647 Compare November 28, 2024 10:59
@ldorau ldorau changed the title [DRAFT] Move level zero helpers to utils Move level zero helpers to utils and use it in benchmarks Nov 28, 2024
@ldorau ldorau force-pushed the Move_level_zero_helpers_to_utils branch from 66b0647 to 32e83ae Compare November 28, 2024 11:06
@ldorau ldorau marked this pull request as ready for review November 28, 2024 11:33
@ldorau ldorau requested a review from a team as a code owner November 28, 2024 11:33
1) Add utils_ze_ prefix to all L0 helper functions.
2) Move level_zero_helpers to utils and rename it to utils_level_zero.
3) Use new utils_level_zero in benchmarks.

Signed-off-by: Lukasz Dorau <[email protected]>
@ldorau ldorau force-pushed the Move_level_zero_helpers_to_utils branch from 32e83ae to 841cd4b Compare November 29, 2024 09:55
@ldorau ldorau requested a review from bratpiorka November 29, 2024 09:55
@lukaszstolarczuk lukaszstolarczuk merged commit 4b18f52 into oneapi-src:main Nov 29, 2024
78 checks passed
@ldorau ldorau deleted the Move_level_zero_helpers_to_utils branch November 29, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants