Skip to content

Revert moving free() to optional (ext) provider ops #953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ldorau
Copy link
Contributor

@ldorau ldorau commented Dec 2, 2024

Description

Revert moving free() to optional (ext) provider ops.

This reverts commit b0bfbb7.

Remove umfDefaultFree() and umfIsFreeOpDefault().

Remove the disable_upstream_provider_free parameter
of the Coarse provider.

Remove the upstreamDoesNotFree argument of
the umfTrackingMemoryProviderCreate() function.

Requires:

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly

@ldorau ldorau requested review from vinser52 and bratpiorka December 2, 2024 10:10
This reverts commit b0bfbb7.

Remove umfDefaultFree() and umfIsFreeOpDefault().

Remove the `disable_upstream_provider_free` parameter
of the Coarse provider.

Remove the `upstreamDoesNotFree` argument of
the `umfTrackingMemoryProviderCreate()` function.

Signed-off-by: Lukasz Dorau <[email protected]>
@ldorau ldorau force-pushed the Revert_Move_free_to_optional_ext_provider_ops branch from 1f78b58 to 3112e2b Compare December 5, 2024 10:09
@ldorau ldorau marked this pull request as ready for review December 5, 2024 10:10
@ldorau ldorau requested a review from a team as a code owner December 5, 2024 10:10
@ldorau
Copy link
Contributor Author

ldorau commented Dec 5, 2024

@bratpiorka @vinser52 please review

@vinser52
Copy link
Contributor

vinser52 commented Dec 5, 2024

@bratpiorka I think it should be part of the 0.10

@ldorau
Copy link
Contributor Author

ldorau commented Dec 5, 2024

@bratpiorka I think it should be part of the 0.10

@vinser52 Are you sure? This change requires libcoarse which is not present in 0.10 ...

@vinser52
Copy link
Contributor

vinser52 commented Dec 5, 2024

@bratpiorka I think it should be part of the 0.10

@vinser52 Are you sure? This change requires libcoarse which is not present in 0.10 ...

We are changing interfaces, the earlier we do that -> less impact for the future users.

Regarding libcoarse, does it impact only file and devdax providers? Can we merge the libcoarse to the 0.10?

@ldorau
Copy link
Contributor Author

ldorau commented Dec 5, 2024

Regarding libcoarse, does it impact only file and devdax providers?

Yes, only file and devdax providers.

@ldorau
Copy link
Contributor Author

ldorau commented Dec 5, 2024

@bratpiorka I think it should be part of the 0.10

@bratpiorka ?

@ldorau ldorau merged commit b7a9b6a into oneapi-src:main Dec 5, 2024
77 checks passed
@bratpiorka
Copy link
Contributor

@vinser52 @ldorau devdax and file providers would not be used in 0.10x and I prefer to minimize the number of changes there at least right now. If we know that there are no major problems with 0.10x, then we could think about merging changes related to the coarse lib (this is a lot of code and multiple PRs).

@ldorau ldorau deleted the Revert_Move_free_to_optional_ext_provider_ops branch December 5, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants