-
Notifications
You must be signed in to change notification settings - Fork 35
Revert moving free()
to optional (ext) provider ops
#953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert moving free()
to optional (ext) provider ops
#953
Conversation
This reverts commit b0bfbb7. Remove umfDefaultFree() and umfIsFreeOpDefault(). Remove the `disable_upstream_provider_free` parameter of the Coarse provider. Remove the `upstreamDoesNotFree` argument of the `umfTrackingMemoryProviderCreate()` function. Signed-off-by: Lukasz Dorau <[email protected]>
1f78b58
to
3112e2b
Compare
@bratpiorka @vinser52 please review |
@bratpiorka I think it should be part of the |
@vinser52 Are you sure? This change requires |
We are changing interfaces, the earlier we do that -> less impact for the future users. Regarding |
Yes, only file and devdax providers. |
|
@vinser52 @ldorau devdax and file providers would not be used in 0.10x and I prefer to minimize the number of changes there at least right now. If we know that there are no major problems with 0.10x, then we could think about merging changes related to the coarse lib (this is a lot of code and multiple PRs). |
Description
Revert moving
free()
to optional (ext) provider ops.This reverts commit b0bfbb7.
Remove
umfDefaultFree()
andumfIsFreeOpDefault()
.Remove the
disable_upstream_provider_free
parameterof the Coarse provider.
Remove the
upstreamDoesNotFree
argument ofthe
umfTrackingMemoryProviderCreate()
function.Requires:
Checklist