-
Notifications
You must be signed in to change notification settings - Fork 35
Update umfOpenIPCHandle API to use IPC handler instead of pool #960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update umfOpenIPCHandle API to use IPC handler instead of pool #960
Conversation
0830a47
to
e3b69de
Compare
should this be ready for review? |
The code part is ready, but I also want to update the |
The |
ff1cdfc
to
1322260
Compare
1322260
to
4ba10e5
Compare
4ba10e5
to
ca07dbb
Compare
Do we need it on 0.10 branch? |
Yes, we need. I will rebase. How do the changes then go to the main branch? Will they be merged automatically or do I need separate PR? |
ca07dbb
to
55cf4ab
Compare
we do PR from 0.10 to main. Like this one:#959 |
Who will do that? Should I do that, or someone from your team do it from time to time? |
Yeah, I do it from time to time, or when need to include a specific patch to the main |
Description
As we agreed on the UMF technical meeting, this PR introduces
umf_ipc_handler_handle_t
that is used by theumfOpenIPCHandle
function instead of pool handle to open the IPC handle. In current implementation theumf_ipc_handler_handle_t
is just a memory provider handle to the tracking provider instance.Checklist