Skip to content

Do not check coverage in the Release multi-numa build #980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ldorau
Copy link
Contributor

@ldorau ldorau commented Dec 9, 2024

Description

  1. Do not check coverage in the Release multi-numa build
  2. Unify the name of the coverage data file in the upload-artifact
    step and the coverage artifact file in the Check coverage step.
    A name of the coverage artifact file in the Check coverage step
    must be unique.

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly

@ldorau ldorau requested a review from a team as a code owner December 9, 2024 08:27
@lukaszstolarczuk
Copy link
Contributor

is it really a fix - was something broken? or just a cleanup in the names?

@ldorau ldorau force-pushed the Fix_names_of_coverage_data_files branch from badcb65 to 7aa0309 Compare December 9, 2024 08:45
@bratpiorka
Copy link
Contributor

is it really a fix - was something broken? or just a cleanup in the names?

fix for sporadic fails like here
https://github.com/oneapi-src/unified-memory-framework/actions/runs/12214905680/job/34076621998?pr=898

@ldorau
Copy link
Contributor Author

ldorau commented Dec 9, 2024

is it really a fix - was something broken? or just a cleanup in the names?

@lukaszstolarczuk This patch fixes the regression introduced by the commits: 9d23a57 and 2a7a229.

@lukaszstolarczuk
Copy link
Contributor

lukaszstolarczuk commented Dec 9, 2024

och, I see you updated the PR now with extra if debug in multinuma, which makes sense.

For GPU workflow it's still a name change only, right? no fix in "logic" needed?

@ldorau
Copy link
Contributor Author

ldorau commented Dec 9, 2024

och, I see you updated the PR now with extra if debug in multinuma, which makes sense.

For GPU workflow it's still a name change only, right? no fix in "logic" needed?

No, in both cases it is a fix for the regression introduced by the commits: 9d23a57 and 2a7a229 because the name of the coverage data file in the upload-artifact step must be exactly the same like $COVERAGE_FILE_NAME in the Check coverage step where this file is generated.

@ldorau ldorau force-pushed the Fix_names_of_coverage_data_files branch from 7aa0309 to 0653a18 Compare December 9, 2024 09:42
@ldorau
Copy link
Contributor Author

ldorau commented Dec 9, 2024

CI builds passed: https://github.com/oneapi-src/unified-memory-framework/actions/runs/12231973390
I have updated only the commit's description.

@ldorau
Copy link
Contributor Author

ldorau commented Dec 9, 2024

@bratpiorka @lukaszstolarczuk please review

@lukaszstolarczuk
Copy link
Contributor

No, in both cases it is a fix for the regression introduced by the commits: 9d23a57 and 2a7a229 because the name of the coverage data file in the upload-artifact step must be exactly the same like $COVERAGE_FILE_NAME in the Check coverage step where this file is generated.

heh, ok, thanks for clarification. The 2 commits you mentioned, introduced many changes, without the description it didn't tell me much.

So now:

  1. why not use the actual variable COVERAGE_FILE_NAME? we already have it composed, don't compose it for the second time, perhaps?
  2. (optional) why did it fail only randomly and sporadically? when the 2 commits were introduced they did not introduce lower coverage score...

@lukaszstolarczuk
Copy link
Contributor

@ldorau, please change the base branch to the v0.10.x

@ldorau ldorau changed the base branch from main to v0.10.x December 9, 2024 10:58
@ldorau ldorau force-pushed the Fix_names_of_coverage_data_files branch from 0653a18 to 695a6f7 Compare December 9, 2024 10:58
@ldorau
Copy link
Contributor Author

ldorau commented Dec 9, 2024

@ldorau, please change the base branch to the v0.10.x

Done

@ldorau
Copy link
Contributor Author

ldorau commented Dec 9, 2024

  1. why not use the actual variable COVERAGE_FILE_NAME? we already have it composed, don't compose it for the second time, perhaps?

@lukaszstolarczuk Done

Copy link
Contributor

@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one thing to confirm yet - I also added CONFIG_NAME in QEMU run_test.sh and it does not match with then name used in workflow (it contains multiple configs per 1 OS)

@ldorau ldorau force-pushed the Fix_names_of_coverage_data_files branch from 695a6f7 to 388457c Compare December 9, 2024 11:48
@ldorau
Copy link
Contributor Author

ldorau commented Dec 9, 2024

just one thing to confirm yet - I also added CONFIG_NAME in QEMU run_test.sh and it does not match with then name used in workflow (it contains multiple configs per 1 OS)

It is OK.
I have checked it again and it turned out that in fact those names does not have to be the same - they have to be only unique and the coverage directories have to contain empty (of size equal 0) coverage data files.

@ldorau ldorau changed the title Fix names of coverage data files Do not check coverage in the Release multi-numa build Dec 9, 2024
1) Do not check coverage in the Release multi-numa build
2) Unify the name of the coverage data file in the `upload-artifact`
   step and the coverage artifact file in the `Check coverage` step.
   A name of the coverage artifact file in the `Check coverage` step
   must be unique.

Signed-off-by: Lukasz Dorau <[email protected]>
@ldorau ldorau force-pushed the Fix_names_of_coverage_data_files branch from 388457c to 8c2c0f8 Compare December 9, 2024 13:58
@lukaszstolarczuk lukaszstolarczuk merged commit 0ee5bd9 into oneapi-src:v0.10.x Dec 9, 2024
0 of 17 checks passed
@ldorau ldorau deleted the Fix_names_of_coverage_data_files branch December 9, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants