-
Notifications
You must be signed in to change notification settings - Fork 35
Do not check coverage in the Release multi-numa build #980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not check coverage in the Release multi-numa build #980
Conversation
is it really a fix - was something broken? or just a cleanup in the names? |
badcb65
to
7aa0309
Compare
fix for sporadic fails like here |
@lukaszstolarczuk This patch fixes the regression introduced by the commits: 9d23a57 and 2a7a229. |
och, I see you updated the PR now with extra For GPU workflow it's still a name change only, right? no fix in "logic" needed? |
No, in both cases it is a fix for the regression introduced by the commits: 9d23a57 and 2a7a229 because the name of the coverage data file in the |
7aa0309
to
0653a18
Compare
CI builds passed: https://github.com/oneapi-src/unified-memory-framework/actions/runs/12231973390 |
@bratpiorka @lukaszstolarczuk please review |
heh, ok, thanks for clarification. The 2 commits you mentioned, introduced many changes, without the description it didn't tell me much. So now:
|
@ldorau, please change the base branch to the v0.10.x |
0653a18
to
695a6f7
Compare
Done |
@lukaszstolarczuk Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just one thing to confirm yet - I also added CONFIG_NAME in QEMU run_test.sh and it does not match with then name used in workflow (it contains multiple configs per 1 OS)
695a6f7
to
388457c
Compare
It is OK. |
1) Do not check coverage in the Release multi-numa build 2) Unify the name of the coverage data file in the `upload-artifact` step and the coverage artifact file in the `Check coverage` step. A name of the coverage artifact file in the `Check coverage` step must be unique. Signed-off-by: Lukasz Dorau <[email protected]>
388457c
to
8c2c0f8
Compare
Description
upload-artifact
step and the coverage artifact file in the
Check coverage
step.A name of the coverage artifact file in the
Check coverage
stepmust be unique.
Checklist