Make coarse_alloc() return aligned address when alignment==0 #981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove incorrect assert in utils_align_ptr_up_size_down(). A pointer is aligned, but a size is only adjusted to the new pointer. The size does not have to be aligned. Signed-off-by: Lukasz Dorau <[email protected]>
ldorau
force-pushed
the
Make_coarse_alloc_return_aligned_address_when_alignment==0
branch
from
7534c78 to
0fd7073
Compare
lplewa
approved these changes
Dec 9, 2024
ldorau
force-pushed
the
Make_coarse_alloc_return_aligned_address_when_alignment==0
branch
2 times, most recently
from
9f65212 to
5d6a252
Compare
Make coarse_alloc() always return address aligned to coarse->page_size when alignment==0. Signed-off-by: Lukasz Dorau <[email protected]>
Make UMF_COARSE_MEMORY_STRATEGY_FASTEST_BUT_ONE the default strategy, because the alignment never equals 0 now. Signed-off-by: Lukasz Dorau <[email protected]>
ldorau
force-pushed
the
Make_coarse_alloc_return_aligned_address_when_alignment==0
branch
from
5d6a252 to
efc620c
Compare
|
@bratpiorka please review |
|
@bratpiorka It should be merged before #976 |
bratpiorka
approved these changes
Dec 10, 2024
ldorau
force-pushed
the
Make_coarse_alloc_return_aligned_address_when_alignment==0
branch
from
efc620c to
62496ed
Compare
ldorau
deleted the
Make_coarse_alloc_return_aligned_address_when_alignment==0
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make
coarse_alloc()always return address aligned tocoarse->page_sizewhenalignment==0.Checklist