Skip to content

Assert in umf_ba_destroy() in DEBUG and UMF_DEVELOPER_MODE #995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ldorau
Copy link
Contributor

@ldorau ldorau commented Dec 16, 2024

Description

if (NDEBUG is not defined) and (UMF_DEVELOPER_MODE is defined)
assert in umf_ba_destroy() if there are any memory leaks
in the base allocator.

It works as a "base-allocator-memory-leaks-checker".

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly

@ldorau ldorau requested a review from a team as a code owner December 16, 2024 08:24
@ldorau ldorau force-pushed the Add_assert0_in_umf_ba_destroy branch from e470c39 to 38108ee Compare December 16, 2024 10:24
@ldorau ldorau marked this pull request as draft December 16, 2024 10:24
@ldorau ldorau force-pushed the Add_assert0_in_umf_ba_destroy branch from 38108ee to 2f5f453 Compare December 16, 2024 11:01
@ldorau ldorau marked this pull request as ready for review December 16, 2024 11:01
@ldorau ldorau marked this pull request as draft December 16, 2024 12:02
@ldorau ldorau force-pushed the Add_assert0_in_umf_ba_destroy branch 2 times, most recently from 12cca40 to 2033783 Compare December 16, 2024 14:17
@ldorau ldorau marked this pull request as ready for review December 17, 2024 07:12
@ldorau ldorau force-pushed the Add_assert0_in_umf_ba_destroy branch from 2033783 to 301c76e Compare December 17, 2024 10:14
@ldorau
Copy link
Contributor Author

ldorau commented Dec 17, 2024

It works as a "base-allocator-memory-leaks-checker".

if (NDEBUG is not defined) and (UMF_DEVELOPER_MODE is defined)
assert in umf_ba_destroy() if there are any memory leaks
in the base allocator.

Signed-off-by: Lukasz Dorau <[email protected]>
@ldorau ldorau force-pushed the Add_assert0_in_umf_ba_destroy branch from 301c76e to c549441 Compare December 18, 2024 08:48
@lukaszstolarczuk lukaszstolarczuk merged commit 7416aa0 into oneapi-src:main Dec 18, 2024
77 checks passed
@ldorau ldorau deleted the Add_assert0_in_umf_ba_destroy branch December 18, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants