Set new div className to relative instead of absolute #1639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 2a59a78 in 1 minute and 55 seconds
More details
- Looked at
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. apps/studio/src/lib/editor/engine/insert/index.ts:43
- Draft comment:
Changing to 'relative' looks correct in getDefaultProperties, but note that createInsertAction still hardcodes the div's position as 'absolute'. Ensure consistency across insertion methods. - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_YsXH74gRT1Lnb3xu
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| @@ -41,7 +41,7 @@ export class InsertManager { | |||
| width: '100px', | |||
| height: '100px', | |||
| backgroundColor: colors.blue[100], | |||
| position: 'absolute', | |||
| position: 'relative', | |||
There was a problem hiding this comment.
The default div style now uses 'relative'. Verify consistency with other div insertions, e.g., in createInsertAction (line 178) still sets position to 'absolute'.
Suggested change
| position: 'relative', | |
| position: 'absolute', |
|
@SoloDevAbu thanks for picking this up, perhaps we should go absolute vs relative based on whether parent is flex or grid? |
ml-delaurier
pushed a commit
to ml-delaurier/nolook
that referenced
this pull request
Apr 23, 2025
t1c1
pushed a commit
to t1c1/onlookbotcodes
that referenced
this pull request
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixed the issue: When a new div is dragged on the canvas, set it to relative instead of absolute.
Related Issues
fixes#1614
Type of Change
Changed the Tailwind CSS property of absolute to relative
Important
Change
positionfromabsolutetorelativefor new divs inInsertManager.getDefaultProperties()inindex.ts.positionfromabsolutetorelativefor newdivelements inInsertManager.getDefaultProperties()inindex.ts.This description was created by
for 2a59a78. It will automatically update as commits are pushed.