Skip to content

Disable elide lines for precommit hooks #1674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2025
Merged

Conversation

Kitenite
Copy link
Contributor

@Kitenite Kitenite commented Mar 25, 2025

Description

Related Issues

Type of Change

  • Bug fix
  • New feature
  • Documentation update
  • Release
  • Refactor
  • Other (please describe):

Testing

Screenshots (if applicable)

Additional Notes


Important

Update pre-commit hooks to use specific linting and formatting scripts without eliding lines.

  • Pre-commit Hooks:
    • Update .husky/pre-commit to use bun run lint:precommit and bun run format:precommit.
  • Scripts:
    • Add format:precommit and lint:precommit scripts in package.json without --elide-lines option.
    • Modify existing format and lint scripts to include --elide-lines 0.

This description was created by Ellipsis for 66af9ba. It will automatically update as commits are pushed.

@Kitenite Kitenite merged commit 8769daa into main Mar 25, 2025
@Kitenite Kitenite deleted the bugs/precommit-elide branch March 25, 2025 19:59
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 66af9ba in 1 minute and 16 seconds

More details
  • Looked at 24 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 6 drafted comments based on config settings.
1. .husky/pre-commit:1
  • Draft comment:
    Pre-commit hook now correctly uses lint:precommit and format:precommit commands.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50%
    None
2. package.json:32
  • Draft comment:
    New precommit scripts remove the --elide-lines option. Ensure these commands produce the desired output for precommit checks.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50%
    None
3. .husky/pre-commit:2
  • Draft comment:
    Updated pre-commit hook to run lint:precommit and format:precommit. Confirm that removing '--elide-lines 0' here is intentional for clearer output during commits.
  • Reason this comment was not posted:
    Confidence changes required: 10% <= threshold 50%
    None
4. package.json:32
  • Draft comment:
    New 'format:precommit' script omits '--elide-lines 0'. Ensure this behavior (full output) is desired during pre-commit.
  • Reason this comment was not posted:
    Confidence changes required: 10% <= threshold 50%
    None
5. package.json:34
  • Draft comment:
    New 'lint:precommit' script now runs without '--elide-lines 0'. Verify that lint output without eliding lines meets your needs during commits.
  • Reason this comment was not posted:
    Confidence changes required: 10% <= threshold 50%
    None
6. package.json:1
  • Draft comment:
    PR title indicates disabling elide lines for pre-commit hooks, but the referenced issue 123 mentions onboarding docs. Confirm that this change addresses the intended issue.
  • Reason this comment was not posted:
    Confidence changes required: 50% <= threshold 50%
    None

Workflow ID: wflow_WRFmSd82foUZIMOH


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

zongkelong pushed a commit to zongkelong/coolook that referenced this pull request Mar 27, 2025
…slation_zh

* 'main' of https://github.com/onlook-dev/onlook:
  Add brand tests (onlook-dev#1675)
  Disable elide lines for precommit hooks (onlook-dev#1674)
  App Panel, Installed Apps, App Details (onlook-dev#1608)
  Modifying configs for linux packages (onlook-dev#1664)
  fix: prevent duplicate variable in tailwind (onlook-dev#1671)
ml-delaurier pushed a commit to ml-delaurier/nolook that referenced this pull request Apr 23, 2025
t1c1 pushed a commit to t1c1/onlookbotcodes that referenced this pull request Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant