-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Release v0.2.21 #1676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v0.2.21 #1676
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested. Reviewed everything up to c49b996 in 1 minute and 57 seconds
More details
- Looked at
53
lines of code in2
files - Skipped
0
files when reviewing. - Skipped posting
4
drafted comments based on config settings.
1. apps/studio/src/routes/editor/EditPanel/StylesTab/single/ColorInput/index.tsx:202
- Draft comment:
Remove outdated commented code (BrandPopoverPicker) to improve clarity. - Reason this comment was not posted:
Confidence changes required:33%
<= threshold50%
None
2. apps/studio/src/routes/editor/LayersPanel/index.tsx:161
- Draft comment:
Confirm that adding the 'hidden' class to the BRAND tab is intentional for this release. - Reason this comment was not posted:
Confidence changes required:33%
<= threshold50%
None
3. apps/studio/src/routes/editor/LayersPanel/index.tsx:161
- Draft comment:
The BRAND tab button now has a 'hidden' class. Confirm that hiding this tab is intentional since BrandTab is still rendered below. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50%
This appears to be an intentional change to hide the BRAND tab button while keeping the underlying functionality. The code is not broken - hiding UI elements while keeping their implementation is a common pattern when features are being temporarily disabled or gradually rolled out. The comment is asking for confirmation of intention, which violates our rules.
The comment could be identifying a legitimate oversight where the developer forgot to remove or hide the BrandTab component. Maybe this is part of a larger feature deprecation that's incomplete.
While that's possible, we should assume the developer knows what they're doing. The comment is essentially asking "are you sure?" which our rules explicitly say to avoid. If this was a mistake, it would likely be caught in testing.
Delete this comment. It's asking for confirmation of intention which our rules explicitly forbid. The code change is straightforward and we should trust the developer's intention.
4. General:0
- Draft comment:
The PR title and description mention improved onboarding docs (Next.js, Remix, Webpack, Babel), but no documentation changes are visible in the diff. Please confirm that the intended documentation updates are included in this release. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
Workflow ID: wflow_9pUA3glggYtFYfPw
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
apps/studio/src/routes/editor/EditPanel/StylesTab/single/ColorInput/index.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on f09caf2 in 54 seconds
More details
- Looked at
13
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
3
drafted comments based on config settings.
1. apps/studio/package.json:4
- Draft comment:
The version bump to 0.2.21 is correct, but the PR description mentions onboarding docs improvements (issue 123) which are not reflected in this diff. Ensure that the release changelog and documentation are updated accordingly. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%
<= threshold50%
The comment is asking the PR author to ensure that the release changelog and documentation are updated, which is similar to asking for updates to the PR description. This violates the rule against asking for updates to the PR description or similar documentation. Therefore, this comment should be removed.
2. apps/studio/package.json:4
- Draft comment:
The PR description promises onboarding docs improvements, but only a version bump is present. Is the documentation update missing? - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%
<= threshold50%
This comment is asking the PR author to confirm if the documentation update is missing, which violates the rule against asking the author to confirm their intention or to update the PR description.
3. apps/studio/package.json:30
- Draft comment:
It appears that the script name 'pree2e' on line 30 may contain a typographical error. Consider renaming it to 'pre-e2e' (or the intended naming convention) for clarity. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
Workflow ID: wflow_Q4VoroWixaXQYis8
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Description
Related Issues
Type of Change
Testing
Screenshots (if applicable)
Additional Notes
Important
Release v0.2.21 with version update and minor code cleanup in
ColorInput
andLayersPanel
.package.json
from0.2.20
to0.2.21
.BrandPopoverPicker
import inColorInput/index.tsx
.BrandPopoverPicker
component usage inColorInput
.hidden
class toBrand
button inLayersPanel/index.tsx
to hide it from the UI.This description was created by
for f09caf2. It will automatically update as commits are pushed.