Skip to content

Add brand translation #1680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2025
Merged

Add brand translation #1680

merged 1 commit into from
Mar 27, 2025

Conversation

Kitenite
Copy link
Contributor

@Kitenite Kitenite commented Mar 27, 2025

Description

Related Issues

Type of Change

  • Bug fix
  • New feature
  • Documentation update
  • Release
  • Refactor
  • Other (please describe):

Testing

Screenshots (if applicable)

Additional Notes


Important

Add translation for 'Brand' tab label in LayersPanel in index.tsx.

  • Translation:
    • Updated LayersPanel in index.tsx to use translation key t('editor.panels.layers.tabs.brand') for the 'Brand' tab label.

This description was created by Ellipsis for b42ecc4. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to b42ecc4 in 26 seconds

More details
  • Looked at 15 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 4 drafted comments based on config settings.
1. apps/studio/src/routes/editor/LayersPanel/index.tsx:170
  • Draft comment:
    Good use of translation key. Ensure 'editor.panels.layers.tabs.brand' exists in the i18n files for proper fallback.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50%
    None
2. apps/studio/src/routes/editor/LayersPanel/index.tsx:170
  • Draft comment:
    Good change: the brand label now uses a translation key. Please ensure that 'editor.panels.layers.tabs.brand' is defined in the translation resources so that it renders correctly.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50%
    This comment is asking the author to ensure that a specific translation key is defined. It is not making a specific code suggestion or pointing out a specific issue with the code. It is more of a reminder or a request for confirmation, which violates the rule against asking the author to ensure something is done.
3. apps/studio/src/routes/editor/LayersPanel/index.tsx:169
  • Draft comment:
    The PR title and issue description refer to onboarding documentation improvements, but the diff only changes the brand translation. Please verify if additional documentation changes are expected.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50%
    This comment is asking the PR author to verify if additional documentation changes are expected, which violates the rule against asking the author to confirm their intention or to update the PR description. It does not provide a specific code suggestion or ask for a specific test to be written.
4. apps/studio/src/routes/editor/LayersPanel/index.tsx:12
  • Draft comment:
    The import statement for the images tab uses './ImageTab' (singular) while the component is referenced as (plural). Please ensure this naming is consistent to avoid potential confusion.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.

Workflow ID: wflow_gKEpBpXUC396DFxQ


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@Kitenite Kitenite merged commit 528ef6d into main Mar 27, 2025
@Kitenite Kitenite deleted the bugs/brand-translation branch March 27, 2025 01:25
ml-delaurier pushed a commit to ml-delaurier/nolook that referenced this pull request Apr 23, 2025
t1c1 pushed a commit to t1c1/onlookbotcodes that referenced this pull request Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant