Skip to content

Quicker build with freestyle #1685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 27, 2025
Merged

Quicker build with freestyle #1685

merged 2 commits into from
Mar 27, 2025

Conversation

Kitenite
Copy link
Contributor

@Kitenite Kitenite commented Mar 27, 2025

Description

Related Issues

Type of Change

  • Bug fix
  • New feature
  • Documentation update
  • Release
  • Refactor
  • Other (please describe):

Testing

Screenshots (if applicable)

Additional Notes


Important

Improves deployment efficiency by using prepareDirForDeployment and updates dependencies in index.ts and bun.lock.

  • Behavior:
    • Replaces serializeFiles with prepareDirForDeployment in index.ts for deployment preparation.
    • Updates sendHostingPostRequest to use DeploymentSource instead of FileRecord.
    • Changes API route to HostingRoutes.DEPLOY_WEB_V2.
  • Dependencies:
    • Adds freestyle-sandboxes as a dependency in package.json.
    • Updates various AWS SDK and other dependencies in bun.lock.
  • Misc:
    • Removes unused dependencies from bun.lock.

This description was created by Ellipsis for 440626f. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 440626f in 2 minutes and 49 seconds

More details
  • Looked at 1973 lines of code in 5 files
  • Skipped 0 files when reviewing.
  • Skipped posting 4 drafted comments based on config settings.
1. package.json:53
  • Draft comment:
    The package.json now adds 'freestyle-sandboxes'@^0.0.35, which fits the build improvements, but the issue description requires adding better onboarding docs for frameworks (Next.js, Remix, Webpack, Babel). It’s unclear if the documentation changes are included elsewhere. Please confirm that the onboarding docs have been added as required.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50%
    The comment is asking the PR author to confirm that onboarding docs have been added, which violates the rule against asking for confirmation or ensuring behavior. It also mentions a dependency change, which should not be commented on unless it's about version consistency or a specific issue. The comment does not provide a specific code suggestion or highlight a specific issue with the code.
2. package.json:53
  • Draft comment:
    The dependency 'freestyle-sandboxes' is added with version ^0.0.35. Verify that this version is correct and stable, and that its inclusion supports the quicker build improvements as intended.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50%
    This comment is about a dependency change, specifically asking to verify the version and its stability. According to the rules, comments on dependency changes or asking for verification of intentions are not allowed. Therefore, this comment should be removed.
3. package.json:17
  • Draft comment:
    The issue requires adding better onboarding docs for frameworks like Next.js, Remix, Webpack, and Babel. This package.json change doesn’t appear to update documentation. Ensure the onboarding docs are updated elsewhere to resolve the issue.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.
4. apps/studio/package.json:30
  • Draft comment:
    Typographical error found in the scripts section: the script name 'pree2e' on line 30 appears to be a typo. If it's intended as a npm lifecycle hook, consider renaming it to 'pre:e2e' for clarity and consistency.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.

Workflow ID: wflow_pBiipmvEOAMTam1O


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@Kitenite Kitenite merged commit d0f779c into main Mar 27, 2025
@Kitenite Kitenite deleted the feat/freestyle-deploy branch March 27, 2025 22:12
zongkelong pushed a commit to zongkelong/coolook that referenced this pull request Mar 28, 2025
…slation_zh

* 'main' of https://github.com/onlook-dev/onlook:
  fix: error when add new color to group (onlook-dev#1683)
  update searching brand color picker (onlook-dev#1681)
  Quicker build with freestyle (onlook-dev#1685)
  Add tool result support (onlook-dev#1684)
  feat: Include tool-result in chat (onlook-dev#1682)
ml-delaurier pushed a commit to ml-delaurier/nolook that referenced this pull request Apr 23, 2025
t1c1 pushed a commit to t1c1/onlookbotcodes that referenced this pull request Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant