Skip to content

Disable web when running dev #1718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 3, 2025
Merged

Disable web when running dev #1718

merged 1 commit into from
Apr 3, 2025

Conversation

Kitenite
Copy link
Contributor

@Kitenite Kitenite commented Apr 3, 2025

Description

Related Issues

Type of Change

  • Bug fix
  • New feature
  • Documentation update
  • Release
  • Refactor
  • Other (please describe):

Testing

Screenshots (if applicable)

Additional Notes


Important

Modify dev script in package.json to exclude @onlook/web package during development.

  • Scripts:
    • Modify dev script in package.json to exclude @onlook/web package when running development environment.

This description was created by Ellipsis for b3b99a7. It will automatically update as commits are pushed.

@Kitenite Kitenite merged commit 28b3dc9 into main Apr 3, 2025
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to b3b99a7 in 30 seconds

More details
  • Looked at 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 4 drafted comments based on config settings.
1. package.json:29
  • Draft comment:
    The change is implemented as intended to disable the web package in dev mode by using the '!@onlook/web' filter.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50%
    None
2. package.json:29
  • Draft comment:
    The PR description and linked issue suggest improvements for onboarding docs, but the change only disables web in dev. Ensure this PR aligns with the related issue.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50%
    This comment is asking the PR author to ensure that the PR aligns with the related issue, which is similar to asking them to confirm their intention or to double-check things. This violates the rule against asking the PR author to confirm their intention or to ensure the behavior is intended. Therefore, this comment should be removed.
3. package.json:29
  • Draft comment:
    The 'dev' script now excludes '@onlook/web' using "!@onlook/web". Please add a comment or documentation explaining why this exclusion is necessary for clarity.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50%
    The comment is asking for documentation or a comment explaining a change, which is not allowed by the rules. It does not provide a specific code suggestion or ask for a test to be written. Therefore, it should be removed.
4. package.json:29
  • Draft comment:
    The PR description mentions improvements to onboarding docs, but the change only disables the web package in dev. Please update the PR title/description to match the code change.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50%
    This comment is asking the PR author to update the PR description, which is against the rules provided. The comment does not provide a specific code suggestion or ask for a test to be written. It is purely about updating the PR description, which is not allowed.

Workflow ID: wflow_KiBnz0ONw5zyL17P


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

zongkelong pushed a commit to zongkelong/coolook that referenced this pull request Apr 3, 2025
…slation_zh

* 'main' of https://github.com/onlook-dev/onlook:
  fix: add validation when create new color group (onlook-dev#1703)
  Disable web when running dev (onlook-dev#1718)
  feat: font panel config (onlook-dev#1666)
  Add web app (onlook-dev#1702)
@Kitenite Kitenite deleted the bugs/filter-web branch April 4, 2025 06:55
ml-delaurier pushed a commit to ml-delaurier/nolook that referenced this pull request Apr 23, 2025
t1c1 pushed a commit to t1c1/onlookbotcodes that referenced this pull request Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant