Skip to content

Add missing mouseaction #1750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2025
Merged

Add missing mouseaction #1750

merged 1 commit into from
Apr 8, 2025

Conversation

Kitenite
Copy link
Contributor

@Kitenite Kitenite commented Apr 8, 2025

Description

Related Issues

Type of Change

  • Bug fix
  • New feature
  • Documentation update
  • Release
  • Refactor
  • Other (please describe):

Testing

Screenshots (if applicable)

Additional Notes


Important

Add MouseAction enum to index.ts in editor package with MOVE, MOUSE_DOWN, and DOUBLE_CLICK.

  • Enums:
    • Add MouseAction enum to index.ts in editor package with MOVE, MOUSE_DOWN, and DOUBLE_CLICK.

This description was created by Ellipsis for 3b1be75. It will automatically update as commits are pushed.

@Kitenite Kitenite merged commit 8d87c3a into main Apr 8, 2025
@Kitenite Kitenite deleted the bugs/mouse-action branch April 8, 2025 06:06
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to 3b1be75 in 1 minute and 48 seconds

More details
  • Looked at 14 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 3 drafted comments based on config settings.
1. packages/models/src/editor/index.ts:47
  • Draft comment:
    MOUSE_DOWN is set to 'click'. Verify that this value is intended and not a misnomer for a mousedown event; consider renaming it to CLICK if that better matches its usage.
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50%
    The comment violates multiple rules: 1) It asks for verification ("Verify that...") which is explicitly discouraged 2) It's speculative about whether this might be wrong 3) Without seeing the actual usage of this enum, we can't be certain if this is actually problematic 4) The comment isn't suggesting a clear required code change, it's asking for clarification.
    Maybe the naming inconsistency between MOUSE_DOWN and 'click' is actually a serious issue that could lead to bugs?
    While the naming might be unconventional, we don't have enough context to know if it's actually problematic in use. The author likely had a reason for this naming choice.
    Delete the comment as it violates multiple review rules by asking for verification, being speculative, and not making a clear required change.
2. packages/models/src/editor/index.ts:45
  • Draft comment:
    The PR title/description mentions onboarding docs, yet the change only adds the MouseAction enum. Update the PR details for clarity and consistency.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50%
    This comment is asking the PR author to update the PR description, which is against the rules. The comment does not provide a specific code suggestion or ask for a test to be written. It is not useful in the context of the rules provided.
3. packages/models/src/editor/index.ts:47
  • Draft comment:
    Typo note: In the 'MouseAction' enum, the MOUSE_DOWN member has its value set to 'click'. For consistency with the naming format used in other enum values (like DOUBLE_CLICK using 'double-click'), consider changing 'click' to 'mouse-down' to clearly indicate it is a mouse down action.
  • Reason this comment was not posted:
    Marked as duplicate.

Workflow ID: wflow_rFxM6BwgABlcCot9


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.


export enum MouseAction {
MOVE = 'move',
MOUSE_DOWN = 'click',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verify that 'click' for MOUSE_DOWN is intentional; consider using 'mouse-down' for clarity if referring to the down event.

Suggested change
MOUSE_DOWN = 'click',
MOUSE_DOWN = 'mouse-down',

ml-delaurier pushed a commit to ml-delaurier/nolook that referenced this pull request Apr 23, 2025
t1c1 pushed a commit to t1c1/onlookbotcodes that referenced this pull request Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant