Resolve the functionality to duplicate a page that has been already duplicated #1776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to ec33733 in 2 minutes and 1 seconds
More details
- Looked at
19lines of code in1files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. apps/studio/src/routes/editor/LayersPanel/Tree/PageTreeNode.tsx:78
- Draft comment:
New path generation always appends '1'. This may cause duplicate naming issues when duplicating a page multiple times. Consider incrementing the suffix (e.g., '2', '3', etc.) to ensure uniqueness. - Reason this comment was not posted:
Marked as duplicate.
2. apps/studio/src/routes/editor/LayersPanel/Tree/PageTreeNode.tsx:78
- Draft comment:
Consider checking if the generated newPath already exists to avoid collisions, especially when duplications occur repeatedly. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 20% vs. threshold = 50%
The comment raises a valid concern about potential path collisions. However, I don't see evidence that pathExists() is a real method on editorEngine.pages. The suggestion assumes implementation details we can't verify. The current code likely relies on the backend to handle collisions appropriately.
I might be wrong about the backend handling - what if it just overwrites existing files silently? Also, the UI could benefit from preventing collisions early.
While collision prevention would be nice, we can't assume the suggested API exists. If there were serious collision issues, they would likely be handled at a more central level.
Delete the comment since it makes assumptions about available APIs and the current error handling approach without strong evidence.
Workflow ID: wflow_JrL0ZaOgjvlIFoTs
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| const basePath = node.data.path; | ||
| const newPath = basePath.replace(/(\/[^/]+)$/, (match) => { | ||
| const baseName = getBaseName(match); | ||
| const newName = `${baseName}1`; |
There was a problem hiding this comment.
Consider the duplication naming logic: appending '1' may lead to unexpected names on multiple duplications (e.g., 'Home' → 'Home1' then 'Home1' → 'Home11').
Kitenite
approved these changes
Apr 15, 2025
zongkelong
pushed a commit
to zongkelong/coolook
that referenced
this pull request
Apr 15, 2025
* 'main' of https://github.com/onlook-dev/onlook: Resolve the functionality to duplicate a page that has been already duplicated (onlook-dev#1776) fix text color changes inconsistently when entering edit mode (onlook-dev#1780)
Kitenite
pushed a commit
that referenced
this pull request
Apr 15, 2025
…uplicated (#1776) * Resolve the functionality to duplicate a page that has been already duplicated
ml-delaurier
pushed a commit
to ml-delaurier/nolook
that referenced
this pull request
Apr 23, 2025
…uplicated (onlook-dev#1776) * Resolve the functionality to duplicate a page that has been already duplicated
t1c1
pushed a commit
to t1c1/onlookbotcodes
that referenced
this pull request
Jun 5, 2025
…uplicated (onlook-dev#1776) * Resolve the functionality to duplicate a page that has been already duplicated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixed when a page duplicated for the first time, then again the page can't be duplicated.
Related Issues
Solved issue #1770
Important
Fixes page duplication issue by modifying
handleDuplicateinPageTreeNode.tsxto generate unique paths.PageTreeNode.tsx.handleDuplicateto generate a unique path by appending '1' to the base name of the page.handleDuplicateinPageTreeNode.tsxto usegetBaseNamefor path generation.This description was created by
for ec33733. It will automatically update as commits are pushed.