feat: realtime manager #1982
Open
feat: realtime manager #1982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts and canvases - Implemented helper functions `user_has_project_access` and `user_has_canvas_access` to check user roles. - Created row-level security policies for `projects`, `canvas`, `user_projects`, `user_canvases`, `frames`, `users`, `user_settings`, and `project_invitations` to enforce access control based on user roles. - Ensured only authenticated users can perform actions based on their roles in the respective tables.
- Added "db:migrate" command to package.json for both bun and drizzle-kit. - Created a GitHub Actions workflow for deploying Supabase migrations, ensuring migrations run on workflow dispatch. - Made existing SQL migrations idempotent by adding checks for type and table existence before creation. - Updated various migration files to drop constraints and types if they exist, enhancing database integrity and flexibility.
- Changed the trigger logic to handle `conversations` and `messages` instead of `frames`, `user_canvases`, and `canvas`. - Updated SQL to ensure project_id is correctly fetched based on the new table structure. - Dropped obsolete triggers and created new ones for `conversations` and `messages` to maintain row-level security policies.
- Created layout component for invitation pages with metadata. - Implemented main component to display invitation details and handle acceptance. - Enhanced API to return inviter information and handle not found cases.
- Integrated useRouter for navigation after accepting an invitation. - Updated acceptInvitationMutation to redirect users to the projects page upon successful acceptance. - Improved code structure by importing necessary hooks from next/navigation.
- Updated the `sendInvitationEmail` function to await the rendering of the invitation email when `dryRun` is true, ensuring the rendered output is correctly logged before returning.
- Introduced `FeatureFlagsProvider` to manage feature flags based on environment variables. - Added `NEXT_PUBLIC_FEATURE_COLLABORATION` flag to control the visibility of the `Members` component in the `TopBar`. - Updated `env.ts` to include the new feature flag and modified `layout.tsx` to wrap the application in the `FeatureFlagsProvider`.
- Added `RealtimeManager` to handle real-time updates for users and frames. - Updated `EditorEngine` and `CanvasManager` to utilize the new `realtime` functionality for broadcasting user updates and frame events. - Enhanced `FramesManager` to send events for frame creation, update, and deletion. - Introduced new types and events in the `realtime` module for better type safety and clarity. - Updated context providers to include `realtimeManager` for managing real-time interactions.
|
@satya-nutella is attempting to deploy a commit to the Onlook Team on Vercel. A member of the Team first needs to authorize it. |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 6f29cf6 in 1 minute and 38 seconds. Click for details.
- Reviewed
349lines of code in9files - Skipped
0files when reviewing. - Skipped posting
5draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. apps/web/client/src/components/store/editor/canvas/index.ts:29
- Draft comment:
Duplicate USER_UPDATED broadcast logic appears in two places. Consider extracting a helper to avoid repetition. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
2. apps/web/client/src/components/store/editor/frames/index.ts:250
- Draft comment:
FRAME_UPDATED events are sent in two different update paths. Confirm if duplicate broadcasting is intentional or if they should be consolidated. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
3. apps/web/client/src/components/store/editor/realtime/manager.ts:66
- Draft comment:
In the send() method, the entire event is sent as payload. Consider sending only event.payload to avoid nested redundancy. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 20% vs. threshold = 50% Without seeing the RealtimeEvent type definition, we can't be sure if event.payload exists or if sending the full event object is actually the intended behavior. The comment makes an assumption about the data structure that we can't verify. The change could potentially break functionality if the receiving end expects the full event object. I might be too cautious - if the type is called RealtimeEvent, it's reasonable to assume it follows a standard event pattern with a payload property. Even if it's a reasonable assumption, we shouldn't make changes to data structures without being completely certain of the type definitions and the requirements of the receiving end. Delete the comment since we don't have enough context to verify if the suggested change is correct or necessary.
4. apps/web/client/src/components/store/editor/realtime/manager.ts:10
- Draft comment:
RealtimeManager.init() relies on projectManager.project.id and logs an error if not set. Consider handling dynamic project changes to reinitialize the subscription when a project becomes available. - Reason this comment was not posted:
Confidence changes required:50%<= threshold50%None
5. PR Description:1
- Draft comment:
The PR title indicates a 'realtime manager' feature, but the description references onboarding docs updates. Please align the PR description with the actual code changes. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
Workflow ID: wflow_4oURyg3n4jIewWow
You can customize 
…/realtime-manager
…lla/onlook into feat/realtime-manager
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Type of Change
Testing
Screenshots (if applicable)
Additional Notes
This PR depends on #1980
Important
Introduce
RealtimeManagerfor handling real-time user and frame events in the editor using Supabase.RealtimeManagerclass inrealtime/manager.tsto manage real-time events using Supabase.USER_UPDATED,FRAME_CREATED,FRAME_UPDATED,FRAME_DELETED.EditorEngineinengine.tsnow includesRealtimeManager.CanvasManagerandFramesManagersend real-time events on user and frame updates.RealtimeEventTypeand event interfaces inrealtime/index.ts.RealtimeUserinterface extendsUserMetadatawith position data.realtimeManagercontext inrealtime/index.tsfor React components.This description was created by
for 6f29cf6. You can customize this summary. It will automatically update as commits are pushed.