Skip to content

Fix typo for intersect-no-queue #633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

romainpi
Copy link
Contributor

I've been having display/animation issues when working with WidgetWrapper.astro.

In some cases the intersect would not trigger the fade-in animations. Looking into it I found myself in components/common/BasicScripts.astro and found the intersect implementation.

Then i found those references to some css class called intercept-no-queue that had no definition.
Noticed the logic linked to the css class intersect-no-queue a saw it was not used anywhere in the code.

After reconnecting those two bits I am no longer having display/animation issues when working with WidgetWrapper.astro.

@romainpi
Copy link
Contributor Author

I've done a bit of digging looking at the commit history.

Commit #38db18b introduced animations.

We can see an implementation for managing elements with the css class intercept-no-queue 38db18b#diff-d187cbee1327974eb3ea8ea421beb19f2a80b9b49dde31dc2afa1aff10c445f3R202

We can also see the css class intercept-no-queue being added to elements in ItemGrid2.astro, WidgetWrapper.astro, Footer.astro, Hero.astro and Hero2.astro.

Later on, in commit #740b96c we see the name changed from intercept-no-queue to intersect-no-queue but no corresponding changes to the elements that were tagged with the css class intercept-no-queue.

It looks like it's either the name intercept-no-queue in BasicScripts.astro that was changed by mistake, or the the css class name inadvertently were not updated in the widgets.

My personal opinion is to keep using the new name intersect-no-queue as it is directly related to the intersect functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant