Skip to content

Json::parseFromStream expects std::string in include/json/reader.h #979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ghost opened this issue Jul 10, 2019 · 1 comment
Closed

Json::parseFromStream expects std::string in include/json/reader.h #979

ghost opened this issue Jul 10, 2019 · 1 comment

Comments

@ghost
Copy link

ghost commented Jul 10, 2019

The definition of "Json::parseFromStream" expects a std::string* in file include/json/reader.h:378.
The definition of "Json::parseFromStream" expects a Json::String* in file src/lib_json/json_reader.cpp:1992.
@baylesj
Copy link
Contributor

baylesj commented Jul 11, 2019

Good catch, I'll push a fix.

@baylesj baylesj mentioned this issue Jul 11, 2019
Merged
baylesj added a commit that referenced this issue Jul 11, 2019
@baylesj
\#979 Fix parseFromStream definition
645250b 
This patch fixes issue #979, where the parseFromStream definition in
the header is different from the implementation.
@baylesj baylesj closed this as completed Jul 17, 2019
res2k pushed a commit to res2k/jsoncpp that referenced this issue Aug 21, 2019
@baylesj @res2k
\open-source-parsers#979 Fix parseFromStream definition
174e5dc 
This patch fixes issue open-source-parsers#979, where the parseFromStream definition in
the header is different from the implementation.
dawesc pushed a commit to EFTlab/jsoncpp that referenced this issue Sep 25, 2019
@baylesj
\open-source-parsers#979 Fix parseFromStream definition
261d963 
This patch fixes issue open-source-parsers#979, where the parseFromStream definition in
the header is different from the implementation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@baylesj