Skip to content

clang-tidy + any_of usage #1171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 12, 2020
Merged

clang-tidy + any_of usage #1171

merged 4 commits into from
May 12, 2020

Conversation

neheb
Copy link
Contributor

@neheb neheb commented May 12, 2020

No description provided.

@neheb
[clang-tidy] change functions to static
b2e9a21 
Found with readability-convert-member-functions-to-static

Signed-off-by: Rosen Penev <[email protected]>
@coveralls
Copy link

coveralls commented May 12, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.06%) to 93.823% when pulling df11b76 on neheb:cll into b8cb888 on open-source-parsers:master.

BillyDonahue
BillyDonahue requested changes May 12, 2020
View reviewed changes
BillyDonahue added a commit to BillyDonahue/jsoncpp that referenced this pull request May 12, 2020
@BillyDonahue
optimize JsonWriter::validate open-source-parsers#1171
3b416b0
@BillyDonahue BillyDonahue mentioned this pull request May 12, 2020
Closed
@neheb
Copy link
Contributor Author

neheb commented May 12, 2020

I think everything has been adressed.

BillyDonahue
BillyDonahue requested changes May 12, 2020
View reviewed changes
BillyDonahue
BillyDonahue requested changes May 12, 2020
View reviewed changes
neheb added 2 commits May 12, 2020 14:26
@neheb
do the same for json_reader
f334fcb 
Signed-off-by: Rosen Penev <[email protected]>
@neheb
use std::any_of
df11b76 
Also simplified two loops.

Signed-off-by: Rosen Penev <[email protected]>
@BillyDonahue BillyDonahue merged commit e36cff1 into open-source-parsers:master May 12, 2020
@BillyDonahue
Copy link
Contributor

Thanks, Rosen!

@neheb neheb deleted the cll branch May 12, 2020 23:30
BillyDonahue added a commit to BillyDonahue/jsoncpp that referenced this pull request May 13, 2020
@BillyDonahue
spot fix open-source-parsers#1171: isprint argument must be represent…
94c3e49 
…able as unsigned char
BillyDonahue added a commit that referenced this pull request May 13, 2020
@BillyDonahue
spot fix #1171: isprint argument must be representable as unsigned ch…
75b360a 
…ar (#1173)
BillyDonahue added a commit to BillyDonahue/jsoncpp that referenced this pull request May 21, 2020
@BillyDonahue
Escape control chars even if emitting UTF8 open-source-parsers#1171
3f0c1a1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillyDonahue BillyDonahue BillyDonahue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neheb @coveralls @BillyDonahue