-
Notifications
You must be signed in to change notification settings - Fork 206
fix: NodeJS sample #1840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: NodeJS sample #1840
Conversation
Overall I like how you simplified the example somewhat by swapping the s3 integration for sts. And I appreciate the effort put into getting this sample way more polished! Your point about cdk makes sense to me, the only reason I'm not sure about that one is that all the other language-specific samples use terraform. As far as I can tell that's just been a decision that was made at some point in the past. But to me it would make sense to keep that uniform accross all language-specific samples here. Maybe this should be a different issue altogether to explore whether we want to switch the samples from terraform over to cdk? |
as discussed during the SIG meeting, I've put back the terraform (with some enhancement to use the hosted pre-built layers)
Let me know if this is looking good :) |
LGTM! |
fixes: #1841
This PR updates the Node.js sample to bring it in line with current practices.
Now that Lambda layers are published, the sample app has been updated to use them.
The telemetry example now uses
STS
instead ofS3
to still demonstrate telemetry capabilities but to avoid potential IAM permission issues caused by misconfigurations asSTS GetCallerIdentidy
does not need any special IAM permissions.The AWS SDK has been upgraded to v3, enabling modular imports.
Infrastructure code has been migrated from
Terraform
toCDK
to reduce external dependencies and improve alignment with the Node.js ecosystem, particularly due to its compatibility with npm-based tooling. Open to reverting this change if there's a strong preference for Terraform.