-
Notifications
You must be signed in to change notification settings - Fork 719
feat: respect supress_instrumentation functionality in dbapi instrumentation #3460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: respect supress_instrumentation functionality in dbapi instrumentation #3460
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a changelog entry.
@emdneto Thank you for review! I updated a changelog. |
@open-telemetry/opentelemetry-python-contrib-approvers Could you take a look at this PR? |
fixed conflict. |
Any chance this could be merged ? |
fixed conflict. |
@open-telemetry/opentelemetry-python-contrib-maintainers Could you take a look at this PR? |
Description
Fixes #3459
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
I tested by unit test and manual test.
Manual test is done by run a below script by
uv run reproduce.py
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.