Skip to content

Use semantic convention attribute for cloud region for botocore API calls #3474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 15, 2025

Conversation

SrdjanLL
Copy link
Contributor

@SrdjanLL SrdjanLL commented May 7, 2025

Description

This change is a result of the conversation on semantic conventions and the correct use of the cloud region attribute (see open-telemetry/semantic-conventions#2142 for details). This PR depends on the semantic conventions update to expand the definition of cloud.region attribute (PR).

Changes made:

  • Update botocore instrumentation to use semantic convention attribute for cloud region
    • Region will no longer be captured as aws.region attribute.
  • Update tests to reflect this change.

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
    • This change removes aws.region from the span attributes in favour of cloud.region which may affect existing functionality.

How Has This Been Tested?

  • Updated unit tests that assert the span attributes.
  • Smoke-tested using the bedrock-runtime examples provided alongside the instrumentation library.

Does This PR Require a Core Repo Change?

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@SrdjanLL SrdjanLL changed the title Update botocore instrumentation to use semantic convention attribute for cloud region Use semantic convention attribute for cloud region for botocore API calls May 7, 2025
@SrdjanLL SrdjanLL requested a review from a team as a code owner May 7, 2025 12:12
@xrmx xrmx enabled auto-merge (squash) May 13, 2025 12:24
@xrmx
Copy link
Contributor

xrmx commented May 13, 2025

Sem conv changes merged so we can merge this too

@xrmx xrmx merged commit 4b9b949 into open-telemetry:main May 15, 2025
720 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants