-
Notifications
You must be signed in to change notification settings - Fork 719
feat(instrumentation-aiohttp-client): Add support for HTTP metrics #3517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(instrumentation-aiohttp-client): Add support for HTTP metrics #3517
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This lgtm; thanks for tests, docstring updates, and consistency with how other instrumentors handle the semconv opt-in.
Would be good to also get other Approver and Maintainer eyes on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I left some changes that I think we should do to not back into this later.
See #3220 for more context
...-instrumentation-aiohttp-client/src/opentelemetry/instrumentation/aiohttp_client/__init__.py
Show resolved
Hide resolved
...-instrumentation-aiohttp-client/src/opentelemetry/instrumentation/aiohttp_client/__init__.py
Show resolved
Hide resolved
...-instrumentation-aiohttp-client/src/opentelemetry/instrumentation/aiohttp_client/__init__.py
Show resolved
Hide resolved
…rc/opentelemetry/instrumentation/aiohttp_client/__init__.py Co-authored-by: Emídio Neto <[email protected]>
…rc/opentelemetry/instrumentation/aiohttp_client/__init__.py Co-authored-by: Emídio Neto <[email protected]>
…rc/opentelemetry/instrumentation/aiohttp_client/__init__.py Co-authored-by: Emídio Neto <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm missing the SERVER_ADDRESS and SERVER_PORT in labels for the duration_histogram_new. They are required. can we set them?
@emdneto the attributes were missing in Spans as well, added both |
oh. Awesome! Thank you |
Description
Added support for metrics in aiohttp-client instrumentation
Fixes #3516
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.