Skip to content

Another async iterator that needs to be consumed with async for #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 12, 2023

Conversation

nfcampos
Copy link
Contributor

No description provided.

Copy link
Contributor

@ddeville ddeville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ddeville ddeville merged commit ef8f1f1 into openai:main Jan 12, 2023
jhallard added a commit that referenced this pull request Jun 5, 2023
…ndle issues (#179)

As reported from the field - we create a `requests.Session` object on first request to the servers and then reuse it indefinitely. This can leave some open
file handles on the OS (not a big deal), but can interact poorly with a bug in Docker Desktop which causes the SDK to entierly break connections to the server.
See #140 for more info.
jhallard added a commit that referenced this pull request Jun 6, 2023
… with Docker Desktop (#478)

* Periodically refresh open `requests.Session`s to mitigate open filehandle issues (#179)

As reported, we create a `requests.Session` object on first request to the servers and then reuse it indefinitely. This can leave some open file handles on the OS (not a big deal), but can interact poorly with a bug in Docker Desktop which causes the SDK to entierly break connections to the server.
See #140 for more info.

The order of items in the API responses is intentional, and this order is clobbered by the rendering of `OpenAIObject`. This change removes the alphabetic sort of response keys
megamanics pushed a commit to devops-testbed/openai-python that referenced this pull request Aug 14, 2024
… with Docker Desktop (openai#478)

* Periodically refresh open `requests.Session`s to mitigate open filehandle issues (openai#179)

As reported, we create a `requests.Session` object on first request to the servers and then reuse it indefinitely. This can leave some open file handles on the OS (not a big deal), but can interact poorly with a bug in Docker Desktop which causes the SDK to entierly break connections to the server.
See openai#140 for more info.

The order of items in the API responses is intentional, and this order is clobbered by the rendering of `OpenAIObject`. This change removes the alphabetic sort of response keys
cgayapr pushed a commit to cgayapr/openai-python that referenced this pull request Dec 14, 2024
cgayapr pushed a commit to cgayapr/openai-python that referenced this pull request Dec 14, 2024
… with Docker Desktop (openai#478)

* Periodically refresh open `requests.Session`s to mitigate open filehandle issues (openai#179)

As reported, we create a `requests.Session` object on first request to the servers and then reuse it indefinitely. This can leave some open file handles on the OS (not a big deal), but can interact poorly with a bug in Docker Desktop which causes the SDK to entierly break connections to the server.
See openai#140 for more info.

The order of items in the API responses is intentional, and this order is clobbered by the rendering of `OpenAIObject`. This change removes the alphabetic sort of response keys
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants