-
Notifications
You must be signed in to change notification settings - Fork 4k
[Azure] CLI: Add support for azure openai chat completion API #359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@athyuttamre could you help review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two non-blocking comments, thanks for the PR!
@athyuttamre Thank you for the review. Updated based on your comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I can cut a new release immediately or we can wait for other PRs (#337) from Microsoft to land. What do you prefer?
@athyuttamre Both should work. As this one works on its own, maybe we can merge it now? |
Great! I need a stamp from a teammate to publish a version, will do so once this is approved: #373. |
This has been published in https://pypi.org/project/openai/0.27.4/. |
The Azure API need to pass parameter
engine
. Follow the patternCompletion.create
to makemodel
optional and addengine
as a parameter too.Tested on Azure OpenAI API passed with