Skip to content

Add benchmarks for openapi-fetch #1299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Add benchmarks for openapi-fetch #1299

merged 1 commit into from
Aug 17, 2023

Conversation

drwpow
Copy link
Contributor

@drwpow drwpow commented Aug 17, 2023

Changes

Adds a Vitest benchmark test used to get rough benchmarks for openapi-fetch’s performance.

Of course, fetch utilities are highly network-dependent, so the benchmark only tests everything but the network request itself.

Axios’ benchmarks may be off because I’m sure the way adapter() is implemented does affect the runtime a little bit. But I didn’t look too much into how that affects it. I would suspect axios’ actual numbers to be a little higher. But not too far off the way I implemented it.

How to Review

N/A

Checklist

N/A

@changeset-bot
Copy link

changeset-bot bot commented Aug 17, 2023

⚠️ No Changeset found

Latest commit: 361d176

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Aug 17, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 361d176
Status: ✅  Deploy successful!
Preview URL: https://470fcbcd.openapi-ts.pages.dev
Branch Preview URL: https://bench.openapi-ts.pages.dev

View logs

@drwpow drwpow force-pushed the bench branch 2 times, most recently from d66c78e to 3f6f4e1 Compare August 17, 2023 05:10
@drwpow drwpow merged commit 067350b into main Aug 17, 2023
@drwpow drwpow deleted the bench branch August 17, 2023 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant