Fix Redoc CLI warning #1465
Merged
Fix Redoc CLI warning #1465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
drwpow
commented
Nov 29, 2023
|
|
||
| ```yaml | ||
| apis: | ||
| core@v2: | ||
| root: ./openapi/openapi.yaml | ||
| openapi-ts: | ||
| x-openapi-ts: |
drwpow
commented
Nov 29, 2023
| @@ -38,6 +38,7 @@ Options | |||
| const OUTPUT_FILE = "FILE"; | |||
| const OUTPUT_STDOUT = "STDOUT"; | |||
| const CWD = new URL(`file://${process.cwd()}/`); | |||
| const REDOC_CONFIG_KEY = "x-openapi-ts"; | |||
There was a problem hiding this comment.
A manually-typed constant 3× was a bug waiting to happen 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #1463 by changing
openapi-tstox-openapi-ts. This is a breaking change, but there’s a helpful migration error for users of the beta version.How to Review
Checklist
docs/updated (if necessary)pnpm run update:examplesrun (only applicable for openapi-typescript)