Skip to content

add logging #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 22, 2022
Merged

add logging #15

merged 2 commits into from
Mar 22, 2022

Conversation

peterdudfield
Copy link
Contributor

Pull Request

Description

add logging to gsp yields latest

How Has This Been Tested?

normal tests

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@peterdudfield peterdudfield self-assigned this Mar 22, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #15 (d192057) into main (a9f2eee) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head d192057 differs from pull request most recent head cb6dff1. Consider uploading reports for the commit cb6dff1 to get more accurate results

@@            Coverage Diff             @@
##             main      #15      +/-   ##
==========================================
+ Coverage   97.45%   97.48%   +0.02%     
==========================================
  Files          16       16              
  Lines         511      516       +5     
==========================================
+ Hits          498      503       +5     
  Misses         13       13              
Impacted Files Coverage Δ
nowcasting_datamodel/read/read_gsp.py 100.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@peterdudfield peterdudfield merged commit e34c518 into main Mar 22, 2022
@peterdudfield peterdudfield deleted the fix-gsp-yield-read branch March 22, 2022 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants