Skip to content

Issue/no nan adjust mw #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 12, 2023
Merged

Issue/no nan adjust mw #195

merged 10 commits into from
Jun 12, 2023

Conversation

peterdudfield
Copy link
Contributor

Pull Request

Description

If there are no ME values, then default to 0. This will allow longer National_xg model to be deployed

How Has This Been Tested?

  • added a test, and checked behaviour

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Merging #195 (f9e2a71) into main (e01682f) will decrease coverage by 0.03%.
The diff coverage is 90.00%.

@@            Coverage Diff             @@
##             main     #195      +/-   ##
==========================================
- Coverage   94.82%   94.79%   -0.03%     
==========================================
  Files          27       27              
  Lines        1603     1613      +10     
==========================================
+ Hits         1520     1529       +9     
- Misses         83       84       +1     
Impacted Files Coverage Δ
nowcasting_datamodel/save/adjust.py 93.33% <81.81%> (-1.01%) ⬇️
nowcasting_datamodel/__init__.py 100.00% <100.00%> (ø)
nowcasting_datamodel/fake.py 100.00% <100.00%> (ø)
nowcasting_datamodel/read/read_metric.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@peterdudfield peterdudfield marked this pull request as ready for review June 12, 2023 13:46
@peterdudfield peterdudfield merged commit 2ddd860 into main Jun 12, 2023
@peterdudfield peterdudfield deleted the issue/no-nan-adjust-mw branch June 12, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant