This repository was archived by the owner on Jun 2, 2025. It is now read-only.
Make PV system dropout type hint optional #297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #297 +/- ##
==========================================
- Coverage 76.55% 76.54% -0.01%
==========================================
Files 125 125
Lines 5924 5923 -1
==========================================
- Hits 4535 4534 -1
Misses 1389 1389 ☔ View full report in Codecov by Sentry. |
Sukh-P
changed the title
Sukh-P
requested review from
jacobbieker and
dfulu
and removed request for
jacobbieker
Sukh-P
commented
Apr 8, 2024
| @@ -1,8 +1,8 @@ | |||
| """Excarta Loading""" | |||
|
|
|||
There was a problem hiding this comment.
this file has changes from the pre commit hook
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Make the system dropout times in the PV configuration optional
How Has This Been Tested?
Checking CI tests still pass
Checklist: