This repository was archived by the owner on Jun 2, 2025. It is now read-only.
improve diff selection #319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
peterdudfield
approved these changes
May 31, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when there were acummulated variables which needed to be diffed, I was doing a compute only on the diffed variables. When the other non-diffed variables were not computed and computed later. This meant loading the same chunks of data twice.
This new pull request removes the compute step so that when compute is run on the output DataArray, each chunk i only loaded once. This also allows us to slice in time or space in either order without much penalty. In the old version slicing in time first would mean loading unnecessary data.
I did a unit speed test on this function locally and it is about twice as fast to loading data than the previous version