Skip to content
This repository was archived by the owner on Jun 2, 2025. It is now read-only.

Add check for lat long location in satellite data spatial slicing #350

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

Sukh-P
Copy link
Member

@Sukh-P Sukh-P commented Jul 30, 2024

Pull Request

Description

For satellite data spatial slicing we currently assume that the central coordinate of interest will be in an osgb coordinate system, which is UK specific, but coordinates of interest can also be in lat long for example for sites outside of the UK this is common. This change will add a check for what coordinate system is being used in the location of interest and then use the appropriate conversion function to geostationary coords.

How Has This Been Tested?

Adding a unit test for this case and running the pipeline on a small sample of data

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@Sukh-P Sukh-P changed the title Add check for lat long location Add check for lat long location in satellite data spatial slicing Jul 31, 2024
@Sukh-P Sukh-P requested a review from peterdudfield July 31, 2024 08:45
@Sukh-P Sukh-P marked this pull request as ready for review July 31, 2024 08:45
@Sukh-P Sukh-P merged commit 92496f1 into main Sep 9, 2024
3 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants