Skip to content
This repository was archived by the owner on Jun 2, 2025. It is now read-only.

FIX batchkey enum bug #351

Merged
merged 1 commit into from
Aug 7, 2024
Merged

FIX batchkey enum bug #351

merged 1 commit into from
Aug 7, 2024

Conversation

AUdaltsova
Copy link
Contributor

@AUdaltsova AUdaltsova commented Aug 6, 2024

Pull Request

On previous merge I added new batchkeys in the middle of the class, which is enumerated, so it bumps all the keys after the new ones 4 down when unpacking premade batches, leading to errors. This PR puts the keys at the bottom, where they should've been in the first place

I think this only affects batches stored as tensors, as .netcdf batches have labels that get converted to BatchKeys.

How Has This Been Tested?

Ran the full battery of PVNet tests locally, for two versions of PVNet: current and with this fix.

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@AUdaltsova AUdaltsova marked this pull request as ready for review August 7, 2024 08:38
Copy link
Member

@Sukh-P Sukh-P left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@AUdaltsova AUdaltsova merged commit 5895f54 into main Aug 7, 2024
5 checks passed
@AUdaltsova AUdaltsova deleted the FIX-batchkey-enum-bug branch August 7, 2024 10:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants