This repository was archived by the owner on Jun 2, 2025. It is now read-only.
FIX batchkey enum bug #351
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
On previous merge I added new batchkeys in the middle of the class, which is enumerated, so it bumps all the keys after the new ones 4 down when unpacking premade batches, leading to errors. This PR puts the keys at the bottom, where they should've been in the first place
I think this only affects batches stored as tensors, as .netcdf batches have labels that get converted to BatchKeys.
How Has This Been Tested?
Ran the full battery of PVNet tests locally, for two versions of PVNet: current and with this fix.
Checklist: