This repository was archived by the owner on Jun 2, 2025. It is now read-only.
Issue/gsp database #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p-database # Conflicts: # ocf_datapipes/load/gsp/gsp.py # ocf_datapipes/production/power_perceiver.py
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## main #47 +/- ##
==========================================
+ Coverage 81.67% 82.41% +0.74%
==========================================
Files 65 67 +2
Lines 2276 2372 +96
==========================================
+ Hits 1859 1955 +96
Misses 417 417
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jacobbieker
approved these changes
Sep 3, 2022
ocf_datapipes/load/gsp/database.py
Outdated
|
|
||
| del gsp_id_to_shape, gsp_pv_power_mw_df | ||
| while True: | ||
| logger.debug(data_array) |
There was a problem hiding this comment.
Would we want to just log this once right before the True? Then it wouldn't clog up debug logs by showing up lots of times?
There was a problem hiding this comment.
thanks, yea ill remove that
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
get GSP data from database
mainly copied from nowcast_dataset
Fixes #45
How Has This Been Tested?
unittest and in big e2e test
Checklist: