add no-padding option to base64 encoding #4
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| local dst = get_string_buf(dlen) | ||
| local r_dlen = C.ngx_http_lua_ffi_encode_base64(s, slen, dst, 0) | ||
| -- if dlen ~= r_dlen then ngx.say ("discrepancy in len") end | ||
| return ffi_string(dst, r_dlen) |
There was a problem hiding this comment.
I think we can avoid the code duplication here? I don't see why we need a branch here in the first place ;) We can just pass down the no_padding argument to those low level functions like base64_encoded_length and C.ngx_http_lua_ffi_encode_base64, right?
agentzh
added a commit
that referenced
this pull request
Mar 19, 2015
…rgument. thanks Shuxin Yang for the patch in #4.
|
Applied a slightly modified version of your patch. Thanks for your work! |
xiaocang
pushed a commit
to xiaocang/lua-resty-core
that referenced
this pull request
Jul 11, 2024
…r at function end.
Avoid inserting new parameters in the middle of the function to prevent core
dumps when using old lua-resty-core with new lua-nginx-module.
Example stack trace:
```
Message: Process 1414245 (nginx) of user 1000 dumped core.
Stack trace of thread 1414245:
#0 0x00007ff596938285 __strlen_avx2 (libc.so.6 + 0x162285)
openresty#1 0x00007ff596f623d2 lj_cf_ffi_string (libluajit-5.1.so.2 + 0x523d2)
openresty#2 0x00007ff596f1bb4b lj_BC_FUNCC (libluajit-5.1.so.2 + 0xbb4b)
openresty#3 0x00007ff596f74223 lua_pcall (libluajit-5.1.so.2 + 0x64223)
openresty#4 0x00000000005044b7 n/a (/home/jiahao/work/org/lua-resty-core/work/nginx/sbin/nginx + 0x1044b7)
```
xiaocang
pushed a commit
to xiaocang/lua-resty-core
that referenced
this pull request
Jul 11, 2024
…r at function end.
Avoid inserting new parameters in the middle of the function to prevent core
dumps when using old lua-resty-core with new lua-nginx-module.
Example stack trace:
```
Message: Process 1414245 (nginx) of user 1000 dumped core.
Stack trace of thread 1414245:
#0 0x00007ff596938285 __strlen_avx2 (libc.so.6 + 0x162285)
openresty#1 0x00007ff596f623d2 lj_cf_ffi_string (libluajit-5.1.so.2 + 0x523d2)
openresty#2 0x00007ff596f1bb4b lj_BC_FUNCC (libluajit-5.1.so.2 + 0xbb4b)
openresty#3 0x00007ff596f74223 lua_pcall (libluajit-5.1.so.2 + 0x64223)
openresty#4 0x00000000005044b7 n/a (/home/jiahao/work/org/lua-resty-core/work/nginx/sbin/nginx + 0x1044b7)
```
xiaocang
pushed a commit
to xiaocang/lua-resty-core
that referenced
this pull request
Jul 15, 2024
…r at function end.
Avoid inserting new parameters in the middle of the function to prevent core
dumps when using old lua-resty-core with new lua-nginx-module.
Example stack trace:
```
Message: Process 1414245 (nginx) of user 1000 dumped core.
Stack trace of thread 1414245:
#0 0x00007ff596938285 __strlen_avx2 (libc.so.6 + 0x162285)
openresty#1 0x00007ff596f623d2 lj_cf_ffi_string (libluajit-5.1.so.2 + 0x523d2)
openresty#2 0x00007ff596f1bb4b lj_BC_FUNCC (libluajit-5.1.so.2 + 0xbb4b)
openresty#3 0x00007ff596f74223 lua_pcall (libluajit-5.1.so.2 + 0x64223)
openresty#4 0x00000000005044b7 n/a (/home/jiahao/work/org/lua-resty-core/work/nginx/sbin/nginx + 0x1044b7)
```
xiaocang
pushed a commit
to xiaocang/lua-resty-core
that referenced
this pull request
Jul 30, 2024
…r at function end.
Avoid inserting new parameters in the middle of the function to prevent core
dumps when using old lua-resty-core with new lua-nginx-module.
Example stack trace:
```
Message: Process 1414245 (nginx) of user 1000 dumped core.
Stack trace of thread 1414245:
#0 0x00007ff596938285 __strlen_avx2 (libc.so.6 + 0x162285)
openresty#1 0x00007ff596f623d2 lj_cf_ffi_string (libluajit-5.1.so.2 + 0x523d2)
openresty#2 0x00007ff596f1bb4b lj_BC_FUNCC (libluajit-5.1.so.2 + 0xbb4b)
openresty#3 0x00007ff596f74223 lua_pcall (libluajit-5.1.so.2 + 0x64223)
openresty#4 0x00000000005044b7 n/a (/home/jiahao/work/org/lua-resty-core/work/nginx/sbin/nginx + 0x1044b7)
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.