UPSTREAM: 2579: added EnableServiceController feature gate to controller (#8)

Signed-off-by: thejasn <[email protected]>

Author: thejasn

docs/deploy/configurations.md

@@ -143,4 +143,5 @@ They are a set of kye=value pairs that describe AWS load balance controller feat
 |---------------------------------------|---------------------------------|-----------------|-------------|
 | ListenerRulesTagging                  | string                          | true           | Enable or disable tagging AWS load balancer listeners and rules |
 | WeightedTargetGroups                  | string                          | true           | Enable or disable weighted target groups |
-| ServiceTypeLoadBalancerOnly           | string                          | false          | If enabled, controller will be limited to reconciling service of type `LoadBalancer`|
+| ServiceTypeLoadBalancerOnly           | string                          | false          | If enabled, controller will be limited to reconciling service of type `LoadBalancer`|
+| EnableServiceController               | string                          | true           | Toggles support for `Service` type resources. |

main.go

@@ -126,9 +126,12 @@ func main() {
 		setupLog.Error(err, "unable to create controller", "controller", "Ingress")
 		os.Exit(1)
 	}
-	if err = svcReconciler.SetupWithManager(ctx, mgr); err != nil {
-		setupLog.Error(err, "Unable to create controller", "controller", "Service")
-		os.Exit(1)
+	// Setup service reconciler only if EnableServiceController is set to true.
+	if controllerCFG.FeatureGates.Enabled(config.EnableServiceController) {
+		if err = svcReconciler.SetupWithManager(ctx, mgr); err != nil {
+			setupLog.Error(err, "Unable to create controller", "controller", "Service")
+			os.Exit(1)
+		}
 	}
 	if err := tgbReconciler.SetupWithManager(ctx, mgr); err != nil {
 		setupLog.Error(err, "unable to create controller", "controller", "TargetGroupBinding")

pkg/config/feature_gates.go

@@ -14,6 +14,7 @@ const (
 	WeightedTargetGroups        Feature = "WeightedTargetGroups"
 	ServiceTypeLoadBalancerOnly Feature = "ServiceTypeLoadBalancerOnly"
 	EndpointsFailOpen           Feature = "EndpointsFailOpen"
+	EnableServiceController     Feature = "EnableServiceController"
 )
 
 type FeatureGates interface {
@@ -45,6 +46,7 @@ func NewFeatureGates() FeatureGates {
 			WeightedTargetGroups:        true,
 			ServiceTypeLoadBalancerOnly: false,
 			EndpointsFailOpen:           false,
+			EnableServiceController:     true,
 		},
 	}
 }