Skip to content

Added feature gate "EnableServiceController" to restrict to only ingress resources #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 8, 2022
Merged

Added feature gate "EnableServiceController" to restrict to only ingress resources #8

merged 1 commit into from
Apr 8, 2022

Conversation

thejasn
Copy link

@thejasn thejasn commented Apr 7, 2022

Signed-off-by: thejasn [email protected]

Issue

kubernetes-sigs#2543

Description

Added a feature gate EnableServiceController which controls when the service reconciler is set up.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@openshift-ci openshift-ci bot requested review from alebedev87 and arjunrn April 7, 2022 12:55
@thejasn thejasn force-pushed the restrict-only-ingress branch from 7477a88 to ff3b49d Compare April 7, 2022 14:08
@arjunrn
Copy link

arjunrn commented Apr 7, 2022

/assign @alebedev87
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 7, 2022
alebedev87
alebedev87 reviewed Apr 7, 2022
View reviewed changes
Copy link

@alebedev87 alebedev87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a comment remark

main.go Outdated
if err = svcReconciler.SetupWithManager(ctx, mgr); err != nil {
setupLog.Error(err, "Unable to create controller", "controller", "Service")
os.Exit(1)
// Setup service reconciler only if AllowServiceType is set to true.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment seems to mention the previous name for the feature gate or flag.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 8, 2022
@thejasn
Copy link
Author

thejasn commented Apr 8, 2022

/label tide/merge-method-squash

@openshift-ci openshift-ci bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Apr 8, 2022
@thejasn thejasn force-pushed the restrict-only-ingress branch from 15b140f to 7bcfb30 Compare April 8, 2022 10:18
@openshift-ci
Copy link

openshift-ci bot commented Apr 8, 2022

@thejasn: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@arjunrn
Copy link

arjunrn commented Apr 8, 2022

/approve
/label px-approved
/label docs-approved
/label qe-approved

@openshift-ci openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR docs-approved Signifies that Docs has signed off on this PR qe-approved Signifies that QE has signed off on this PR labels Apr 8, 2022
@openshift-ci
Copy link

openshift-ci bot commented Apr 8, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arjunrn, thejasn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2022
@alebedev87
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 8, 2022
@openshift-merge-robot openshift-merge-robot merged commit f175872 into openshift:main Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alebedev87 alebedev87 alebedev87 left review comments

@arjunrn arjunrn Awaiting requested review from arjunrn

Assignees

@arjunrn arjunrn

@alebedev87 alebedev87

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thejasn @arjunrn @alebedev87 @openshift-merge-robot