UPSTREAM <carry>: OCPBUGS-24653: Ensure FIPS compliance for controller image #21

alebedev87 · 2024-04-03T10:16:35Z

Replaced the base image with a non-UBI variant.
Added the 'strictfipsruntime' tag to the controller binary.

check-payload scan:

$ git log -1
commit b84e919edb49f66ee1b3f538490f3d756c5edc42 (HEAD -> fips-compliance, origin/fips-compliance)
Author: Andrey Lebedev <[email protected]>
Date:   Wed Apr 3 12:12:41 2024 +0200

    UPSTREAM <carry>: OCPBUGS-24653: Ensure FIPS compliance for controller image
    
    - Replaced the base image with a non-UBI variant.
    - Added the 'strictfipsruntime' tag to the controller binary.

$ podman build -t quay.io/alebedev/aws-load-balancer-controller:b84e919ed -f Dockerfile.openshift .
...
Successfully tagged quay.io/alebedev/aws-load-balancer-controller:b84e919ed
Successfully tagged quay.io/alebedev/aws-load-balancer-controller:3.4.1140
015b97227b263e93e08c9265b0cc9007c30d8c569591c0437e16df3069c894f7

$ podman push quay.io/alebedev/aws-load-balancer-controller:b84e919ed
Getting image source signatures
Copying blob 013e3dbc52ff skipped: already exists  
Copying blob fc72b3d90f88 skipped: already exists  
Copying config 015b97227b done  
Writing manifest to image destination

$ podman run --privileged registry.ci.openshift.org/ci/check-payload:latest scan operator --spec quay.io/alebedev/aws-load-balancer-controller:b84e919ed
I0403 10:32:34.093944       1 main.go:302] using embedded config
I0403 10:32:34.094271       1 types_config.go:12] using config ...
I0403 10:32:34.094342       1 main.go:102] "scan" version="0.3.1-91-ga0d1e0d3-dirty"
---- Successful run

…r image - Replaced the base image with a non-UBI variant. - Added the 'strictfipsruntime' tag to the controller binary.

openshift-ci-robot · 2024-04-03T10:16:40Z

@alebedev87: This pull request references Jira Issue OCPBUGS-24653, which is invalid:

expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Replaced the base image with a non-UBI variant.

Added the 'strictfipsruntime' tag to the controller binary.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

alebedev87 · 2024-04-03T10:19:15Z

/jira refresh

openshift-ci-robot · 2024-04-03T10:19:19Z

@alebedev87: This pull request references Jira Issue OCPBUGS-24653, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.16.0) matches configured target version for branch (4.16.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @lihongan

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2024-04-03T10:22:05Z

@alebedev87: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci-robot · 2024-04-03T10:34:37Z

@alebedev87: This pull request references Jira Issue OCPBUGS-24653, which is invalid:

expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Replaced the base image with a non-UBI variant.
Added the 'strictfipsruntime' tag to the controller binary.

$ git log -1
commit b84e919edb49f66ee1b3f538490f3d756c5edc42 (HEAD -> fips-compliance, origin/fips-compliance)
Author: Andrey Lebedev <[email protected]>
Date:   Wed Apr 3 12:12:41 2024 +0200

   UPSTREAM <carry>: OCPBUGS-24653: Ensure FIPS compliance for controller image
   
   - Replaced the base image with a non-UBI variant.
   - Added the 'strictfipsruntime' tag to the controller binary.

$ podman build -t quay.io/alebedev/aws-load-balancer-controller:b84e919ed -f Dockerfile.openshift .
...
Successfully tagged quay.io/alebedev/aws-load-balancer-controller:b84e919ed
Successfully tagged quay.io/alebedev/aws-load-balancer-controller:3.4.1140
015b97227b263e93e08c9265b0cc9007c30d8c569591c0437e16df3069c894f7

$ podman push quay.io/alebedev/aws-load-balancer-controller:b84e919ed
Getting image source signatures
Copying blob 013e3dbc52ff skipped: already exists  
Copying blob fc72b3d90f88 skipped: already exists  
Copying config 015b97227b done  
Writing manifest to image destination

$ podman run --privileged registry.ci.openshift.org/ci/check-payload:latest scan operator --spec quay.io/alebedev/aws-load-balancer-controller:b84e919ed
I0403 10:32:34.093944       1 main.go:302] using embedded config
I0403 10:32:34.094271       1 types_config.go:12] using config ...
I0403 10:32:34.094342       1 main.go:102] "scan" version="0.3.1-91-ga0d1e0d3-dirty"
---- Successful run

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

alebedev87 · 2024-04-03T10:52:31Z

/jira refresh

openshift-ci-robot · 2024-04-03T10:52:35Z

@alebedev87: This pull request references Jira Issue OCPBUGS-24653, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.16.0) matches configured target version for branch (4.16.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @lihongan

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

lihongan · 2024-04-03T11:03:05Z

/label qe-approved

Miciah · 2024-04-03T11:53:14Z

Thanks!
/approve
/lgtm
/hold
in case @gcs278 wants to review.

At some point, would it make sense to squash all the "UPSTREAM" commits that update Dockerfile.openshift, in order to make rebases easier?

openshift-ci · 2024-04-03T11:54:09Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~DOWNSTREAM_OWNERS~~ [Miciah]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

alebedev87 · 2024-04-03T11:57:55Z

At some point, would it make sense to squash all the "UPSTREAM" commits that update Dockerfile.openshift, in order to make rebases easier?

Good point. I think this should be done - yes.

Miciah · 2024-04-03T13:15:19Z

At some point, would it make sense to squash all the "UPSTREAM" commits that update Dockerfile.openshift, in order to make rebases easier?

Good point. I think this should be done - yes.

To be clear, I'm not saying you need to do this now. Maybe next time we rebase on a new upstream release.

gcs278 · 2024-04-03T14:17:28Z

Thanks!
/lgtm
/unhold

openshift-ci-robot · 2024-04-03T14:21:55Z

@alebedev87: Jira Issue OCPBUGS-24653: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-24653 has been moved to the MODIFIED state.

In response to this:

Replaced the base image with a non-UBI variant.
Added the 'strictfipsruntime' tag to the controller binary.

check-payload scan:

$ git log -1
commit b84e919edb49f66ee1b3f538490f3d756c5edc42 (HEAD -> fips-compliance, origin/fips-compliance)
Author: Andrey Lebedev <[email protected]>
Date:   Wed Apr 3 12:12:41 2024 +0200

   UPSTREAM <carry>: OCPBUGS-24653: Ensure FIPS compliance for controller image
   
   - Replaced the base image with a non-UBI variant.
   - Added the 'strictfipsruntime' tag to the controller binary.

$ podman build -t quay.io/alebedev/aws-load-balancer-controller:b84e919ed -f Dockerfile.openshift .
...
Successfully tagged quay.io/alebedev/aws-load-balancer-controller:b84e919ed
Successfully tagged quay.io/alebedev/aws-load-balancer-controller:3.4.1140
015b97227b263e93e08c9265b0cc9007c30d8c569591c0437e16df3069c894f7

$ podman push quay.io/alebedev/aws-load-balancer-controller:b84e919ed
Getting image source signatures
Copying blob 013e3dbc52ff skipped: already exists  
Copying blob fc72b3d90f88 skipped: already exists  
Copying config 015b97227b done  
Writing manifest to image destination

$ podman run --privileged registry.ci.openshift.org/ci/check-payload:latest scan operator --spec quay.io/alebedev/aws-load-balancer-controller:b84e919ed
I0403 10:32:34.093944       1 main.go:302] using embedded config
I0403 10:32:34.094271       1 types_config.go:12] using config ...
I0403 10:32:34.094342       1 main.go:102] "scan" version="0.3.1-91-ga0d1e0d3-dirty"
---- Successful run

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

UPSTREAM <carry>: OCPBUGS-24653: Ensure FIPS compliance for controlle…

b84e919

…r image - Replaced the base image with a non-UBI variant. - Added the 'strictfipsruntime' tag to the controller binary.

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 3, 2024

openshift-ci bot requested review from frobware and Miciah April 3, 2024 10:18

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 3, 2024

openshift-ci bot requested a review from lihongan April 3, 2024 10:19

openshift-ci-robot removed the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Apr 3, 2024

openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Apr 3, 2024

openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Apr 3, 2024

openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Apr 3, 2024

openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Apr 3, 2024

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 3, 2024

openshift-ci bot assigned Miciah Apr 3, 2024

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 3, 2024

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 3, 2024

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 3, 2024

openshift-ci bot assigned gcs278 Apr 3, 2024

openshift-merge-bot bot merged commit 105552e into openshift:main Apr 3, 2024

alebedev87 mentioned this pull request Apr 3, 2024

OCPBUGS-24653: bump FIPS compliant controller image openshift/aws-load-balancer-operator#134

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

UPSTREAM <carry>: OCPBUGS-24653: Ensure FIPS compliance for controller image #21

UPSTREAM <carry>: OCPBUGS-24653: Ensure FIPS compliance for controller image #21

Uh oh!

alebedev87 commented Apr 3, 2024 •

edited

Loading

Uh oh!

openshift-ci-robot commented Apr 3, 2024

Uh oh!

alebedev87 commented Apr 3, 2024

Uh oh!

openshift-ci-robot commented Apr 3, 2024

Uh oh!

openshift-ci bot commented Apr 3, 2024

Uh oh!

openshift-ci-robot commented Apr 3, 2024

Uh oh!

alebedev87 commented Apr 3, 2024

Uh oh!

openshift-ci-robot commented Apr 3, 2024

Uh oh!

lihongan commented Apr 3, 2024

Uh oh!

Miciah commented Apr 3, 2024

Uh oh!

openshift-ci bot commented Apr 3, 2024

Uh oh!

alebedev87 commented Apr 3, 2024

Uh oh!

Miciah commented Apr 3, 2024

Uh oh!

gcs278 commented Apr 3, 2024

Uh oh!

openshift-ci-robot commented Apr 3, 2024

Uh oh!

Uh oh!

UPSTREAM <carry>: OCPBUGS-24653: Ensure FIPS compliance for controller image #21

UPSTREAM <carry>: OCPBUGS-24653: Ensure FIPS compliance for controller image #21

Uh oh!

Conversation

alebedev87 commented Apr 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Apr 3, 2024

Uh oh!

alebedev87 commented Apr 3, 2024

Uh oh!

openshift-ci-robot commented Apr 3, 2024

Uh oh!

openshift-ci bot commented Apr 3, 2024

Uh oh!

openshift-ci-robot commented Apr 3, 2024

Uh oh!

alebedev87 commented Apr 3, 2024

Uh oh!

openshift-ci-robot commented Apr 3, 2024

Uh oh!

lihongan commented Apr 3, 2024

Uh oh!

Miciah commented Apr 3, 2024

Uh oh!

openshift-ci bot commented Apr 3, 2024

Uh oh!

alebedev87 commented Apr 3, 2024

Uh oh!

Miciah commented Apr 3, 2024

Uh oh!

gcs278 commented Apr 3, 2024

Uh oh!

openshift-ci-robot commented Apr 3, 2024

Uh oh!

Uh oh!

alebedev87 commented Apr 3, 2024 •

edited

Loading