UPSTREAM: <carry>: Switch to UBI for builder image #7
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: arjunrn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
The build image should use UBI.
|
@arjunrn: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/label docs-approved |
openshift-ci
bot
added
docs-approved
|
|
||
| WORKDIR /workspace | ||
| WORKDIR /opt/app-root/src | ||
|
|
||
| # Copy the dependencies which don't change frequently |
There was a problem hiding this comment.
We should reduce layers and just do a COPY . ., we can add a .dockerignore for other files.
There was a problem hiding this comment.
That would reduce the layer but increases the build time for the container because the layer changes every time one file in the entire directory changes. Then go has to download all the dependencies, and rebuild everything again.
|
/lgtm |
The build image should use UBI.